Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update first release procedure #2640

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −2
Open

Update first release procedure #2640

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
252beed
Update first_release.md
maxulysse Jul 10, 2024
558272b
Update first_release.md
maxulysse Jul 10, 2024
dcc262a
[automated] Fix code linting
nf-core-bot Jul 10, 2024
a7ae992
Update sites/docs/src/content/docs/tutorials/adding_a_pipeline/first_…
maxulysse Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sites/docs/src/content/docs/tutorials/adding_a_pipeline/first_release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,15 @@ Not to worry, we're a friendly bunch.

To get your pipeline reviewed for its initial release, do the following:

1. Make a pull-request from the `dev` branch to `master` on the nf-core fork. This is a
1. Create a new branch based on `TEMPLATE`, called `TEMPLATE_<TOOLS_VERSION>` from the version of the TEMPLATE (i.e., latest tools sync) that is in the `dev` branch you wish merge into `master`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not make the PR directly against TEMPLATE?

The commit message from @nf-core-bot will help you figure what was the tools versions used.
maxulysse marked this conversation as resolved.
Show resolved Hide resolved
For example, if this commit message `Template update for nf-core/tools version 1.13` is the one that used for a tools sync,
the branch should be called `TEMPLATE_1.13`.

2. Make a pull-request from the `dev` branch to this `TEMPLATE_<TOOLS_VERSION>` branch on the nf-core fork. This is a
special case and all of the tests should pass.

1. Once the tests are passing, request a review from the core team. You can use the
3. Once the tests are passing, request a review from the core team. You can use the
[#request-review](https://app.slack.com/client/TE6CZUZPH/CQY2U5QU9) slack channel for this.

What happens next depends on the state of your master branch:
Expand Down
Loading