-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evidence stats page #2695
Open
edmundmiller
wants to merge
22
commits into
main
Choose a base branch
from
stats-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Evidence stats page #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will get updated later
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial rewrite I threw together yesterday(emphasis on how quick this was to set up and get hacking on).
I pulled the database off mysql and tossed it in motherduck(This could also probably be a csv on hugging face or S3 if MotherDuckd wants to get greedy)
Scripts and some data: https://huggingface.co/datasets/nf-core/stats/blob/main/db/README.md(this was the hardest part getting connected to the DB 😅)
Threw the credentials in the Evidence template and it was off to the races.
https://nf-core-stats.evidence.app/
Some questions answered
At first I started out with a separate repo because I couldn't get it to
npm run dev
when I tossed it in the website repo. It's kinda of a Evidence bug, kinda an issue with npm workspaces. I tried switching to pnpm, and it just worked. That's definately a seperate debate, but just calling it out, so bear with me if that's a blocker this is a PoC.Just deployed it with their cloud offering because it was a click. They have netlify instructions or you just build it yourself.
It runs as a static site generator. I think we just stick with that while I prove out recreating the current stats page. I'm hoping there's some way to just injest the charts or components, but I think worst case scenario, we can just wrap the html in Astro, like what's happening with the old site currently. Just need to pull in the theming.
Main point is it's the kind of dev workflow that I think will let the community hack on it. It's simple, and quick to get up to speed, and I'll be excited to see what people build with it!
Closes #570 #571
Out standing Tasks and Decissions