Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

March 2024 hackathon sites #2921

Merged
merged 19 commits into from
Jan 13, 2025
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Jan 11, 2025

Todo:

  • Go through cleaning up the address front matter (mostly just deleting in most cases)
  • Manually fetch GPS coordinates for each site (even if only approximate)
  • Sanity check all sites.

@netlify /events/2025/hackathon-march-2025/bogota-colombia

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit ae050f5
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/6784e5bc7fc6800008c3f40d
😎 Deploy Preview https://deploy-preview-2921--nf-core-main-site.netlify.app/events/2025/hackathon-march-2025/bogota-colombia
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot deleted a comment from netlify bot Jan 11, 2025
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked some pages.

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put the countries in the subtitle when reviewing on GH, but looking at the website, It hink it would be better to put countries in the shorttitle (maybe as emojis if space is an issue).

There are too many acronyms whihc IMO makes it harder to see where they are actually from... country info front and center will help people narrow down possible places faster (before making their own)

Also, minor thing: clicking on the 'read more' links on the main page jumps to the page content so you don't see the header with the actual address info... maybe would be worth copying the address to the body of the text too.

One more thing: should we already have a 'register interest in attending form' for all? And if so, maybe add a little note on all site pages saying 'please see the main hackathon event page for the centralised attendee registration' or something - so people don't keep only checking the site-specific page?

Co-authored-by: James A. Fellows Yates <[email protected]>
@ewels
Copy link
Member Author

ewels commented Jan 12, 2025

I've put the countries in the subtitle when reviewing on GH, but looking at the website, It hink it would be better to put countries in the shorttitle (maybe as emojis if space is an issue).

There are too many acronyms whihc IMO makes it harder to see where they are actually from... country info front and center will help people narrow down possible places faster (before making their own)

The table in the index page has both country and flag emoji already, as well as a map. But yeah, happy to also include this info on the individual pages as well if helpful.

Also, minor thing: clicking on the 'read more' links on the main page jumps to the page content so you don't see the header with the actual address info... maybe would be worth copying the address to the body of the text too.

Sure, doesn't hurt.

One more thing: should we already have a 'register interest in attending form' for all? And if so, maybe add a little note on all site pages saying 'please see the main hackathon event page for the centralised attendee registration' or something - so people don't keep only checking the site-specific page?

Yes good idea. Could do it a bit like how we do for bytesize talks - with a standard little info box on each site-specific page saying "go here to the main page for info and registration".

@jfy133
Copy link
Member

jfy133 commented Jan 12, 2025

I've put the countries in the subtitle when reviewing on GH, but looking at the website, It hink it would be better to put countries in the shorttitle (maybe as emojis if space is an issue).

There are too many acronyms whihc IMO makes it harder to see where they are actually from... country info front and center will help people narrow down possible places faster (before making their own)

The table in the index page has both country and flag emoji already, as well as a map. But yeah, happy to also include this info on the individual pages as well if helpful.

Yes, but I'm thinking from the PoV of someone who goes to one of the site pages, and goes hrm maybe not that one - rather than having to go back to the main page they can just use the side bar to go to the next site in the same country.

Also, minor thing: clicking on the 'read more' links on the main page jumps to the page content so you don't see the header with the actual address info... maybe would be worth copying the address to the body of the text too.

Sure, doesn't hurt.

👍

One more thing: should we already have a 'register interest in attending form' for all? And if so, maybe add a little note on all site pages saying 'please see the main hackathon event page for the centralised attendee registration' or something - so people don't keep only checking the site-specific page?

Yes good idea. Could do it a bit like how we do for bytesize talks - with a standard little info box on each site-specific page saying "go here to the main page for info and registration".

Yes exactly!

@ewels
Copy link
Member Author

ewels commented Jan 13, 2025

ok, I've addressed everything I can there @jfy133

Hopefully good to merge now!

Note that there could be some refactoring done to make this a bit nicer, not sure how happy @mashehu will be with my event-specific layout for example 😬 It'd also be good to have broken-up frontmatter fields and to automatically build the table on the main event page. But I suggest that we merge this now and come back to that.

@jfy133 jfy133 self-requested a review January 13, 2025 10:10
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to order sidebar by country, but this is sufficient for now!

@ewels ewels merged commit 99a45bb into nf-core:main Jan 13, 2025
12 checks passed
@ewels ewels deleted the march-2024-hackathon-sites branch January 13, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants