Skip to content

Commit

Permalink
Merge pull request #11 from nfa-vfxim/feature/issue-8/add-sound-to-ma…
Browse files Browse the repository at this point in the history
…ya-playblast-publishes

fix code non sounded playblast, adding correct calculation for handles
  • Loading branch information
mervinvb authored Jan 13, 2025
2 parents 16d20a7 + 76ea5ec commit 975d4fa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions python/tk_multi_reviewsubmission2/review_dialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def __init__(self, app, parent=None):

audio_nodes = maya.cmds.ls(type="audio")
self.audio_filename = None
self.audio_offset = None
for audio_node in audio_nodes:
if audio_node is None: # Skip if the audio_node is None
continue
Expand Down
5 changes: 2 additions & 3 deletions python/tk_multi_reviewsubmission2/slate.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@
fps = float(sys.argv[14])
logo_path = sys.argv[15]
sound_path = sys.argv[16]
sound_offset = int(float(sys.argv[17]))

sound_offset = int(float(sys.argv[17])) if sys.argv[17] != "None" else None
output_node = None

version_padding = 3
Expand Down Expand Up @@ -110,7 +109,7 @@ def __get_quicktime_settings():
settings["mov64_fps"] = fps
if os.path.isfile(sound_path):
settings["mov64_audiofile"] = sound_path
settings["mov64_audio_offset"] = sound_offset - 1000
settings["mov64_audio_offset"] = sound_offset - (first_frame - 1)
settings["mov64_units"] = "Frames"

# setting output colorspace
Expand Down

0 comments on commit 975d4fa

Please sign in to comment.