Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search rework #615

Merged
merged 40 commits into from
Feb 5, 2025
Merged

Search rework #615

merged 40 commits into from
Feb 5, 2025

Conversation

Freymaurer
Copy link
Collaborator

  • new term search ✨
  • Updated test setup
  • Updated Component project
  • Added storybook ui tests
  • Added tib search support for new term search
  • Added nuget package for Components project
  • Added npm package for Components project
  • Initial setup for publish workflows (current testing state for after merge into main)

@Freymaurer Freymaurer linked an issue Feb 4, 2025 that may be closed by this pull request
10 tasks
@Etschbeijer
Copy link
Collaborator

grafik
Enable filling of multiple cells or adapt the text please

@Etschbeijer
Copy link
Collaborator

grafik
Maybe relace the word "link" with "source"? It is a bit more descriptive
Move the icon with the cog to the top right, that is the same place we use it in the new Templates UI and so it looks a bit more in line.

@Freymaurer
Copy link
Collaborator Author

grafik Maybe relace the word "link" with "source"? It is a bit more descriptive Move the icon with the cog to the top right, that is the same place we use it in the new Templates UI and so it looks a bit more in line.

Renamed to Source Link, as Source already exists 50px above.

But I disagree with moving the cog to the top of the modal, as we do not allow to make adjustments to the current element, instead if functions as a display of used functions and should be lower priority.

For example:

  • Nobody scrolls to the bottom of all youtube videos to make adjustments to a search
  • But when you are currently viewing a video, the video is in the focus and metadata can be found on the bottom

@Freymaurer
Copy link
Collaborator Author

grafik Enable filling of multiple cells or adapt the text please

Works as expected, allowing to fill multiple rows, but not multiple columns as the error message indicates:

image

@Freymaurer Freymaurer merged commit 7cea49c into main Feb 5, 2025
2 checks passed
@Freymaurer Freymaurer deleted the search_rework branch February 14, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new term search component
2 participants