Add comment column to normal swate with manually adaptable name #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freymaurer
requested changes
Feb 14, 2025
| @@ -86,7 +86,13 @@ let private SearchBuildingBlockHeaderElement (ui: BuildingBlockUIState, setUi, m | |||
| // Dropdown building block type choice | |||
| Dropdown.Main(ui, setUi, model, dispatch) | |||
| // Term search field | |||
| if state.HeaderCellType.HasOA() then | |||
| if state.HeaderCellType = CompositeHeaderDiscriminate.Comment then | |||
| Daisy.input [ | |||
There was a problem hiding this comment.
missing prop.defaultValue
| @@ -179,14 +185,15 @@ let private AddBuildingBlockButton (model: Model) dispatch = | |||
| [<ReactComponent>] | |||
| let Main (model: Model) dispatch = | |||
| let state_bb, setState_bb = React.useState(BuildingBlockUIState.init) | |||
| let inputValue, setInputValue = React.useState "" | |||
There was a problem hiding this comment.
please put this into BuildingBlock.Model with a more descriptive name
There was a problem hiding this comment.
we want to share the same information between page switches. Everything in the ReactComponent is lost when switching to another page
There was a problem hiding this comment.
to clarify: "page" means sidebar tab
Freymaurer
requested changes
Feb 14, 2025
| @@ -185,15 +188,15 @@ let private AddBuildingBlockButton (model: Model) inputValue dispatch = | |||
| [<ReactComponent>] | |||
| let Main (model: Model) dispatch = | |||
| let state_bb, setState_bb = React.useState(BuildingBlockUIState.init) | |||
| let inputValue, setInputValue = React.useState "" | |||
| let commentHeader, setCommentHeader = React.useState model.AddBuildingBlockState.CommentHeader | |||
There was a problem hiding this comment.
This is really bad style!! Just use the value straight from model. No sense in binding it one more time to a react state
Freymaurer
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #591