Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite passer, rusher, receiver on abnormal plays with penalties #435

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

mrcaseb
Copy link
Member

@mrcaseb mrcaseb commented Oct 9, 2023

closes #434

on abnormal plays with penalties
@mrcaseb mrcaseb requested a review from guga31bb October 9, 2023 15:35
@mrcaseb
Copy link
Member Author

mrcaseb commented Oct 9, 2023

Tests are failing because this play now lists Cohen as rusher

"(13:01) (Shotgun) 29-T.Cohen FUMBLES (Aborted) at CHI 37, and recovers at CHI 39. PENALTY on GB-97-K.Clark, Defensive Holding, 5 yards, enforced at CHI 43 - No Play."

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

@mrcaseb mrcaseb merged commit c1ca9f2 into master Oct 10, 2023
@mrcaseb mrcaseb deleted the abnormal-plays-with-penalties branch October 10, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Abnormal Plays" overwrite passer, receiver, and rusher on plays with penalties
2 participants