Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly aggregate conversion rates #440

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Correctly aggregate conversion rates #440

merged 2 commits into from
Oct 30, 2023

Conversation

mrcaseb
Copy link
Member

@mrcaseb mrcaseb commented Oct 20, 2023

closes #439

@mrcaseb
Copy link
Member Author

mrcaseb commented Oct 20, 2023

We now chose group variables depending on the value of the argument weekly. This avoid summary problems and improves performance.

@mrcaseb mrcaseb requested a review from guga31bb October 20, 2023 21:01
@mrcaseb mrcaseb enabled auto-merge (squash) October 20, 2023 21:02
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

🚀 Deployed on https://6532eb7812f6941c7bf5d82c--thirsty-brown-d38ddf.netlify.app

tanho63
tanho63 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrcaseb mrcaseb merged commit 257dee6 into master Oct 30, 2023
6 checks passed
@mrcaseb mrcaseb deleted the series-aggregation branch October 30, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanho63 tanho63 tanho63 approved these changes

@guga31bb guga31bb Awaiting requested review from guga31bb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calculate_series_conversion_rates(weekly = FALSE) incorrectly summarizes percentages to season level
2 participants
@mrcaseb @tanho63