clean up internal namespace and directly re-export nflreadr functions #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanho63
force-pushed
the
tan/maintenance
branch
from
c525c8d to
5da2401
Compare
tanho63
changed the title
mrcaseb
requested changes
Jan 25, 2025
| @@ -52,6 +52,7 @@ Imports: | |||
| glue, | |||
| janitor, | |||
| lifecycle, | |||
| magrittr, | |||
There was a problem hiding this comment.
I would like to get rid of the magrittr pipe and never imported it because the pipe is reexported in dplyr and we need to watch the number of dependencies
| #' @importFrom cli rule | ||
| #' @importFrom curl curl_fetch_memory | ||
| #' @importFrom nflreadr load_pbp load_player_stats load_schedules load_rosters nflverse_sitrep | ||
| #' @importFrom magrittr %>% |
| #' @importFrom utils packageVersion | ||
| #' @importFrom xgboost getinfo |
There was a problem hiding this comment.
nflfastR needs xgboost to apply the models but there is no actual function call to xgboost which results in a R CMD Check note. That's why I import a dummy.
| #' } | ||
| #' } | ||
| #' @export | ||
| report <- function(...) nflreadr::nflverse_sitrep(...) |
There was a problem hiding this comment.
Not happy with silently dropping the function report completely
| @@ -466,7 +466,6 @@ fast_scraper <- function(game_ids, | |||
|
|
|||
| #' Load Team Rosters for Multiple Seasons | |||
| #' @details See [`nflreadr::load_rosters`] for details. | |||
| #' @inheritDotParams nflreadr::load_rosters | |||
There was a problem hiding this comment.
This produces in a check warning
|
General comment on this is that there are some situations where we didn't namespace the function call. In sum_playstats it's for performance reasons. In other cases probably no reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.