Merge pull request #22 from schmidtk/feat-import-plugin

feat(import): add import rules that meet current style

index.js

@@ -1,9 +1,13 @@
 "use strict";
 
 module.exports = {
-  "extends": "google",
+  "extends": [
+    "google",
+    "plugin:import/recommended"
+  ],
   "plugins": [
     "google-camelcase",
+    "import",
     "jsdoc",
     "opensphere"
   ],
@@ -71,6 +75,23 @@ module.exports = {
     //
     "prefer-promise-reject-errors": "off",
 
+    //
+    // Custom rules from eslint-plugin-import
+    //
+
+    // Warn when importing something marked as @deprecated
+    "import/no-deprecated": "warn",
+
+    // Do not allow importing using an absolute path (ie, '/some/path')
+    "import/no-absolute-path": "error",
+    // Do not allow relative paths to sibling projects (ie, '../some-project/src/index.js')
+    "import/no-relative-packages": "error",
+    // Do not allow relative paths to parents (ie, use full module path instead of '../')
+    // TODO: This is a breaking change from how we have been handling imports, and should be enabled in a major release.
+    // "import/no-relative-parent-imports": "error",
+    // Do not allow a module to import itself
+    "import/no-self-import": "error",
+
     //
     // Custom rules from eslint-plugin-opensphere
     //

package.json

@@ -2,6 +2,7 @@
   "dependencies": {
     "eslint-config-google": "^0.14.0",
     "eslint-plugin-google-camelcase": "^0.0.2",
+    "eslint-plugin-import": "^2.24.2",
     "eslint-plugin-jsdoc": "^36.0.6",
     "eslint-plugin-opensphere": "^2.5.0"
   },