Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc admin attribute form updates #223

Closed
wants to merge 5 commits into from

Conversation

kbrownomni
Copy link
Contributor

For Arcgis plugin: Put admin, events and layers each in cards. Pulled admin attributes out of dialog and into a reactive form.

@kbrownomni kbrownomni self-assigned this Oct 14, 2024
@Skosche3
Copy link
Contributor

Add visual to reference
image
image

@Skosche3
Copy link
Contributor

@newmanw made some changes to the UI that will need to be accounted for.
See "Add Feature Service" section
image
image

Copy link
Contributor

@Skosche3 Skosche3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments. I can take a look again once you catch up to latest changes on develop/

<form [formGroup]="attributesForm">
<div class="edit-attributes-form">
<div class="observation-id-field">
<mat-form-field [style.width.%]="90" appearance="fill">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is what is controlling the width of the Attribute fields but they extend across the page. Maybe shorten some to fit the field length needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modeled this 90% width after the sfts plugin UI. I'll check with Billy and see how he'd like it to look.

@kbrownomni kbrownomni force-pushed the arc-admin-attribute-form-updates branch from 22a043a to ff3a971 Compare October 15, 2024 20:16
@kbrownomni kbrownomni closed this Oct 23, 2024
@kbrownomni kbrownomni deleted the arc-admin-attribute-form-updates branch October 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants