-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arc admin attribute form updates #223
Conversation
@newmanw made some changes to the UI that will need to be accounted for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments. I can take a look again once you catch up to latest changes on develop/
plugins/arcgis/web-app/projects/main/src/lib/arc-admin/arc-admin.component.ts
Outdated
Show resolved
Hide resolved
<form [formGroup]="attributesForm"> | ||
<div class="edit-attributes-form"> | ||
<div class="observation-id-field"> | ||
<mat-form-field [style.width.%]="90" appearance="fill"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is what is controlling the width of the Attribute fields but they extend across the page. Maybe shorten some to fit the field length needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modeled this 90% width after the sfts plugin UI. I'll check with Billy and see how he'd like it to look.
22a043a
to
ff3a971
Compare
For Arcgis plugin: Put admin, events and layers each in cards. Pulled admin attributes out of dialog and into a reactive form.