Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BANDSB rework #499

Closed

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Mar 5, 2024

This updates the existing BANDSB implementation to parse representative sample data. It extracts data from the same sample used for MATESA, and builds on #497 infrastructure.

The key changes are to the TRE parsing, because BANDSB uses a four-byte float representation (i.e. IEEE-754 binary) as well as the more typical ASCII encoded floating point values (and hyphen-minus fill versions of that). I've added 'f' for the ASCII floating point representation, and 'F754' for the IEEE-754 binary representation. A better name would be appreciated.

@bradh bradh marked this pull request as ready for review March 18, 2024 10:14
@pressler-vsc
Copy link
Collaborator

Thanks for this PR @bradh; especially for including the test data and test. We had a few concerns (and found another underlying SarPy bug) for which we've submitted a slightly different approach in #502. Does the modified behavior in that PR still address your use case?

@bradh
Copy link
Contributor Author

bradh commented Mar 28, 2024

Haven't tried it, but I don't see any problems. Will close this in favour of #502.

@bradh bradh closed this Mar 28, 2024
@bradh bradh deleted the BANDSB_integration branch April 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants