Skip to content

ihealth integration #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ihealth integration #168

wants to merge 3 commits into from
+167 −22

Conversation

mrajagopal
Copy link
Collaborator

@mrajagopal mrajagopal commented Jul 18, 2025 •
edited
Loading

Proposed changes

  • Job.Collect now returns filenames (without contents held in JobResult type) in addition to error and skipped status
  • Some files from the exec-dqlite-dump were written directly in the job instead of being returned as part of the JobResult; this has been corrected and returned as a JobResult
  • Added GenerateManifest method and associated structures to generate a manifest.json file for iHealth ingestion
  • The generated tarball no longer extracts into a dedicated directory; this has been done as part of iHealth's requirement for ingestion with the manifest.json present in the root directory of the tarball

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@mrajagopal
Feat: Generate a manifest file for ihealth ingestion
ccfcb82
@mrajagopal
Feat: Generate a manifest file for ihealth ingestion
4c91202 
* Job.Collect now returns filenames in addition to error and skipped status
* Some files from the nim-dqlite-job were written directly in the job instead of being returned as part of the JobResult, this was corrected in a previous commit
* Added GenerateManifest and associated structures to generate a manifest.json file for iHealth ingestion
@mrajagopal mrajagopal self-assigned this Jul 18, 2025
@mrajagopal mrajagopal linked an issue Jul 18, 2025 that may be closed by this pull request
Generate support package suitable for iHealth ingestion #169
Open
@mrajagopal mrajagopal added the enhancement New feature or request label Jul 18, 2025
@mrajagopal mrajagopal marked this pull request as ready for review July 18, 2025 01:28
@mrajagopal mrajagopal requested a review from dareste July 18, 2025 01:28
@mrajagopal mrajagopal changed the title Ihealth integration ihealth integration Jul 18, 2025
@mrajagopal
Fix: Issue 164: Capture output of exec to files before overall job fa…
0da9305 
…ilure check

* Otherwise we fail to capture output from running pods when there is at least one other pod containing the same pod string such as nginx-ingress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dareste dareste Awaiting requested review from dareste

At least 1 approving review is required to merge this pull request.

Assignees

@mrajagopal mrajagopal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate support package suitable for iHealth ingestion
1 participant
@mrajagopal