Introduced crypto.subtle.generateCertificate(). #947
+3,248
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimZhestikov
force-pushed
the
gen-ssl-cert
branch
3 times, most recently
from
754a353 to
e83fb52
Compare
VadimZhestikov
force-pushed
the
gen-ssl-cert
branch
6 times, most recently
from
aba3246 to
3ed2ad0
Compare
Previously, r.setReturnValue() had to be used when returning a value from async js_set handler.
async function hash(r) {
let hash = await crypto.subtle.digest('SHA-512', r.headersIn.host);
r.setReturnValue(Buffer.from(hash).toString('hex'));
}
Now r.setReturnValue() is not needed:
async function hash(r) {
let hash = await crypto.subtle.digest('SHA-512', r.headersIn.host);
return Buffer.from(hash).toString('hex');
}
In addition, infinite microtask loops detection is added.
It fixes _766 on GitHub.
VadimZhestikov
force-pushed
the
gen-ssl-cert
branch
from
3ed2ad0 to
02abac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #766 on GitHub.