Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPv3 and QUIC related changes #353
HTTPv3 and QUIC related changes #353
Changes from 7 commits
6840277
20a79b1
9a01c86
110d75f
e6e44c5
0ae9613
c77912c
629a4e0
9d0f4f6
ac50e23
cd31d83
65eada3
c01d989
c1ea961
35335c8
49564ac
483fc3b
58a8d48
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simplify this a little bit I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As convenient as it is, this really should be included in the http3/quic template. Directives in this template belong exclusively to the
ngx_core_module
.Instead, I would tweak the
nginx.conf.j2
template to something along the lines ofAnd we can then use scopes (!) to make sure that only the
quic_bpf
parameter/directive can be used here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, IMO, bpf settings should be moved to core module in nginx as well. But I get the point. I'll move it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.