Theme: Add dark-mode #371
Draft
Theme: Add dark-mode #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview will be available once build job completes!
|
Use https://xyproto.github.io/splash/docs/github-dark.html as Theme for dark mode light-dark css merge handled by chad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark and
:root[data-theme="dark"]/:root[data-theme="light"]to handle theme switches without needing to add a "dark" class throughout the code.The
jsfor this is directly in the<head>so it should trigger as early as possible during bootstrap.I tried to make this work with zero js, but from what I understand there's no way to "save" your selected theme without it triggering a flash. It is possible if we only rely on system theme... but at least in my use, I often pick light/dark on a site by site basis.
The non-js version will always be light theme.