Fix callouts with headers in tab groups not rendering #430
+1
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Callouts with headers (important, caution, warning, and deprecated) and no custom title were incorrectly rendering inside of tab groups. This fix prevents that by checking if there is a title, if not it uses the typing of the call-out.
In addition I've removed the deprecated examples within the site, so only up-to-date examples are on it.
I've included the before and after for callouts within tab groups and outside of. There has been noticeable change to regular, non-tabbed, loud callouts.
This is in response to this issue: nginx/documentation#1163
Thanks @JTorreG for the clarification on the issue and your workaround!
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)