Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidebar swapper #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add sidebar swapper #89

wants to merge 1 commit into from

Conversation

nginx-jack
Copy link
Collaborator

@nginx-jack nginx-jack commented Oct 10, 2024 •
edited
Loading

Proposed changes

Add sidebar swapper.
Expected behaviour:

  • On visiting the page without having used useNewTheme, the current side bar should be visible
  • After running useNewTheme(true) in your browser console, the sidebar should be replaced with the text "Sidebar placeholder" and the new theme should be visible
  • Running useNewTheme(false) should revert back to the current styling
  • Refreshing the page should keep the same state as before the refresh, be it theme true or theme false

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@nginx-jack nginx-jack requested a review from a team October 10, 2024 13:31
@nginx-jack nginx-jack marked this pull request as ready for review October 10, 2024 13:31
lamATnginx
lamATnginx approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works when trying with Luke to show mainframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@lamATnginx lamATnginx lamATnginx approved these changes

@Jcahilltorre Jcahilltorre Awaiting requested review from Jcahilltorre Jcahilltorre is a code owner

@travisamartin travisamartin Awaiting requested review from travisamartin travisamartin is a code owner

@LukeBillington LukeBillington Awaiting requested review from LukeBillington LukeBillington is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nginx-jack @ADubhlaoich @lamATnginx