Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user to set kube-rbac-proxy image #358

Merged
merged 3 commits into from
Aug 9, 2024
Merged

allow user to set kube-rbac-proxy image #358

merged 3 commits into from
Aug 9, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 8, 2024 •
edited
Loading

Proposed changes

  • allow user to set kube-rbac-proxy image & tag via Makefile variables KRP_IMAGE_BASE & KRP_IMAGE_TAG
  • set containerImage value when VERSION variable changes
  • make it clear which values in the templates are placeholders
  • bump minimum kubernetes version to 1.26

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 8, 2024 14:38
@pdabelf5 pdabelf5 changed the title allow customer to set kube-rbac-proxy image allow user to set kube-rbac-proxy image Aug 9, 2024
@pdabelf5 pdabelf5 merged commit 27b85ff into main Aug 9, 2024
6 checks passed
@pdabelf5 pdabelf5 deleted the set-proxy-image branch August 9, 2024 08:40
@pdabelf5 pdabelf5 linked an issue Aug 13, 2024 that may be closed by this pull request
POC - Operator - Image registry consolidation #348
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

Assignees

@j1m-ryan j1m-ryan

@vepatel vepatel

@pdabelf5 pdabelf5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POC - Operator - Image registry consolidation
4 participants
@pdabelf5 @j1m-ryan @vepatel @jjngx