Skip to content

Lab2 and 5 edits #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

Lab2 and 5 edits #54

merged 2 commits into from
Jul 28, 2025

Conversation

sdutta9
Copy link
Collaborator

@sdutta9 sdutta9 commented Jul 28, 2025

Proposed changes

  • Renamed nginx-repo.jwt to license.jwt within lab2 guide as that is the name which is present in udf and also referred to in lab5.
  • Minor lab5 corrections that was captured by field SE while going through the guide

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the naming of the NGINX license file and corrects minor documentation issues in the lab guides. The changes ensure consistency between lab2 and lab5 by using the unified license.jwt filename and fixing line number references.

  • Renamed nginx-repo.jwt to license.jwt in lab2 guide to match the actual filename in UDF
  • Corrected line number reference in lab5 from line 75 to line 74
  • Fixed file path reference in lab5 from lab5/license.jwt to lab2/license.jwt

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
labs/lab2/readme.md Updates license file references from nginx-repo.jwt to license.jwt
labs/lab5/readme.md Corrects line number reference and fixes license file path reference

Copy link
Collaborator

@apcurrier apcurrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sdutta9 sdutta9 merged commit 3aca024 into main Jul 28, 2025
1 check passed
@sdutta9 sdutta9 deleted the sd2 branch July 28, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants