Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetMaxAPIVersion to get max supported API #337

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add GetMaxAPIVersion to get max supported API #337

merged 1 commit into from
Aug 9, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 9, 2024

Proposed changes

Closes #222

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome requested a review from a team as a code owner August 9, 2024 01:38
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Aug 9, 2024
sjberman
sjberman reviewed Aug 9, 2024
View reviewed changes
client/nginx.go Outdated Show resolved Hide resolved
client/nginx_test.go Show resolved Hide resolved
@lucacome lucacome merged commit 1e17ec4 into main Aug 9, 2024
13 checks passed
@lucacome lucacome deleted the feat/max-api-version branch August 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose max API version
3 participants
@lucacome @sjberman @j1m-ryan