Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize CLI flag usage ('=' vs ' ') #1176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joelhans
Copy link
Contributor

I started to poke around at this, and think it's likely not as pervasive an issue as I had previously thought.

I don't want to touch anything under the current Endpoints heading (HTTP, TCP, TLS), since those going away with #1006. I'm finding others here and there, but mostly in relation to modules, which, again, we are trying to move from anyway.

Anyway—I've found some and tested them to make sure they still work. I may come back for more later. Useful command to find instances, by replacing url= with the flag you're looking for.

grep -Ril --exclude-dir node_modules/ --exclude-dir build/ -e "url="

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview Feb 14, 2025 0:24am

@S3Prototype
Copy link
Collaborator

Thanks for taking a look at this @joelhans! Yeah, no worries on stopping the work here. We'll get these changes merged into the revamp PR (#1105) and I'll make a linear issue to follow up and finish this off when that's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants