Implement Target Metadata #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/controller
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@jonstacks I chose not to factor out the config file for the api binary for simplicity in implementing the metadata for now. We can always go back and use a config file for settings. |
Sounds good to me. I've logged #478 for simplifying the config |
jonstacks
approved these changes
Oct 30, 2024
hjkatz
force-pushed
the
hkatz/metadata
branch
from
a7c43f9 to
911d7c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what the change is solving
Implement propagating the target metadata (annotations and labels) to the target service created by BoundEndpoint
How
Describe the solution
Add util.ParseHelmDictionary()
Use util.ParseHelmDictionary() for --ngrok-metadata
Add serviceAnnotations and serviceLabels flags to api binary
Propagate target metadata to target service
Breaking Changes
Are there any breaking changes in this PR?
No.