Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Any custom implementations of
EntityCollectionDataService
, particularly those extendingDefaultDataService
have to import related interfaces with a deep import (e.g.import { HttpOptions } from '@ngrx/data/src/dataservices/interfaces';
. Some Typescript compiler option configurations have issues with this, since it is not possible to import from specific files not mentioned in the package.json exports.What is the new behavior?
Export HttpOptions under
@ngrx/data
, so that custom EntityCollectionDataService implementations can use it.Does this PR introduce a breaking change?
Other information