Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): export HttpOptions #4564

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Nosfistis
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Any custom implementations of EntityCollectionDataService, particularly those extending DefaultDataService have to import related interfaces with a deep import (e.g. import { HttpOptions } from '@ngrx/data/src/dataservices/interfaces';. Some Typescript compiler option configurations have issues with this, since it is not possible to import from specific files not mentioned in the package.json exports.

What is the new behavior?

Export HttpOptions under @ngrx/data, so that custom EntityCollectionDataService implementations can use it.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Export HttpOptions under `@ngrx/data`, so that custom EntityCollectionDataService implementations can use it.
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit fc247af
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67102ef793f8020008151712

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already export QueryParams, which is the deprecated version of HttpOptions I do think this is fine to export.

@brandonroberts brandonroberts merged commit 4909627 into ngrx:main Oct 29, 2024
11 checks passed
@Nosfistis Nosfistis deleted the bugfix/export-http-options branch October 29, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants