Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(logger-plugin): extract ActionLogger for logging action lifecycle #1262

Merged
merged 3 commits into from
Aug 24, 2019

Conversation

markwhitfeld
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the reason for refactoring?

The logger plugin has so many responsibilities mixed in one place that it is a real effort to figure out what is happening. This refactoring is in preparation for adding a fix for issue #276, #213 and #561

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@markwhitfeld markwhitfeld requested a review from arturovt August 23, 2019 20:20
@markwhitfeld
Copy link
Member Author

Should be good to go in my opinion. @arturovt could you review?

@markwhitfeld markwhitfeld merged commit abbc0aa into master Aug 24, 2019
@arturovt arturovt deleted the refactor/extract-action-logger branch August 24, 2019 12:58
@markwhitfeld markwhitfeld added this to the 3.5.x milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants