Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(store): tree-shake deepFreeze #1821

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@splincode
Copy link
Member

@arturovt hello, please, trigger CI

@arturovt arturovt force-pushed the perf/tree-shake-freeze branch from 007ec56 to b32f93a Compare February 1, 2022 11:20
@splincode
Copy link
Member

really strange, why CI works for PR #1820

@arturovt
Copy link
Member Author

arturovt commented Feb 1, 2022

Circle doesn't like me.

@splincode
Copy link
Member

I really want migrate to Github Actions, it's easy for support

@arturovt @markwhitfeld what do you think?

@markwhitfeld
Copy link
Member

@splincode Yes, I agree, although there is nothing stopping us from leveraging both.
You were going to work on this a few months back. Did you look at this at all?
ngxs-labs/platform#1

@splincode
Copy link
Member

@markwhitfeld after moving to a new team (https://github.com/tinkoff/taiga-ui), I could not yet find the time ((

@arturovt arturovt force-pushed the perf/tree-shake-freeze branch from b32f93a to 228a95c Compare February 12, 2022 06:56
@arturovt arturovt force-pushed the perf/tree-shake-freeze branch from 228a95c to 171907f Compare February 18, 2022 13:56
@markwhitfeld markwhitfeld merged commit d470dff into master Feb 28, 2022
@markwhitfeld markwhitfeld deleted the perf/tree-shake-freeze branch February 28, 2022 19:25
@markwhitfeld markwhitfeld added this to the v3.7.4 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants