refactor: move metadata into internals #2062
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3222457. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Files updated (2)
Total files change -217B -0.16% Final result: ✅ View report in BundleMon website ➡️ |
arturovt
force-pushed
the
refactor/move-metadata
branch
7 times, most recently
from
7b6aae7 to
3222457
Compare
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
| @@ -28,7 +28,7 @@ function areArgumentsShallowlyEqual( | |||
| * | |||
| * @ignore | |||
| */ | |||
| export function memoize<T extends (...args: any[]) => any>( | |||
| export function ɵmemoize<T extends (...args: any[]) => any>( | |||
There was a problem hiding this comment.
Shouldn't this be aliased with the barred-o in the internals package exports as opposed to internally within the package?
There was a problem hiding this comment.
I think we could make all of the namings without barred-o and re-export them with ɵ, but this package is 'exports-only', which means it only exports the stuff which is used outside. As thus I'm guessing this would've been an extra code.
| ɵMETA_OPTIONS_KEY, | ||
| ɵSELECTOR_META_KEY | ||
| } from './symbols'; | ||
| export * from './symbols'; |
There was a problem hiding this comment.
We are exposing a lot more here than originally intended.
Do we have an option to not expose so much?
There was a problem hiding this comment.
Everything which is exported from there is used outside.
This commit includes several updates: 1) Moves metadata interfaces and functions to the `@ngxs/store/internals` subpackage. 2) Transfers interfaces and objects from `plugin_api.ts` to the `@ngxs/store/plugins` subpackage. 3) Adds the `@deprecated` annotation to functions and types that were exported from `public_to_deprecate.ts`.
arturovt
force-pushed
the
refactor/move-metadata
branch
from
3222457 to
25a5a4d
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 25a5a4d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
|
Code Climate has analyzed commit 25a5a4d and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 97.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.0% change). View more on Code Climate. |
This commit includes several updates:
@ngxs/store/internalssubpackage.plugin_api.tsto the@ngxs/store/pluginssubpackage.@deprecatedannotation to functions and types that wereexported from
public_to_deprecate.ts.