-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(websocket-plugin): do not dispatch action when root injector is destroyed #2257
Conversation
…estroyed Prevents dispatching `WebSocketDisconnected` action in `ngOnDestroy` hook of the `WebSocketHandler`. The `ngOnDestroy` hook is called after root injector has been destroyed, meaning that no dispatch stuff should be done.
0aa5bbf
to
4aab4ac
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4aab4ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
commit: |
Code Climate has analyzed commit 4aab4ac and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
BundleMonUnchanged files (6)
No change in files bundle size Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (1)
Unchanged files (8)
Total files change +20B +0.09% Groups updated (1)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (2)
Unchanged files (1)
Total files change +42B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
Prevents dispatching
WebSocketDisconnected
action inngOnDestroy
hook of theWebSocketHandler
. ThengOnDestroy
hook is called after root injector has been destroyed, meaning that no dispatch stuff should be done.