Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): add root store initializer guard #2278

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(store): add root store initializer guard #2278

merged 1 commit into from
Dec 18, 2024

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Dec 17, 2024

In this commit, we are adding the root store initializer guard, which ensures that
provideStore() is not accidentally called multiple times (e.g., in feature-level
providers such as route providers).

In this commit, we are adding the root store initializer guard, which ensures that
`provideStore()` is not accidentally called multiple times (e.g., in feature-level
providers such as route providers).
@arturovt arturovt linked an issue Dec 17, 2024 that may be closed by this pull request
@arturovt arturovt marked this pull request as ready for review December 17, 2024 23:31
Copy link

nx-cloud bot commented Dec 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8091e46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Dec 17, 2024

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2278

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2278

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2278

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2278

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2278

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2278

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2278

commit: 8091e46

Copy link

bundlemon bot commented Dec 17, 2024

BundleMon

Files updated (1)
Status Path Size Limits
fesm2022/ngxs-store.mjs
102.36KB (+511B +0.49%) 103KB / +0.5%
Unchanged files (5)
Status Path Size Limits
fesm2022/ngxs-store-internals.mjs
11.29KB 13KB / +0.5%
fesm2022/ngxs-store-internals-testing.mjs
6.8KB 7KB / +0.5%
fesm2022/ngxs-store-operators.mjs
6.22KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
2.38KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
574B 2KB / +0.5%

Total files change +511B +0.39%

Groups updated (1)
Status Path Size Limits
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
31.13KB (+119B +0.37%) +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Dec 17, 2024

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
4.03KB +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
3.01KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
2.61KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
2.57KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
2.44KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
2.14KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
2.01KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
861B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
396B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
20.04KB +0.5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Dec 17, 2024

BundleMon (Integration Projects)

Files added (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
+66.37KB +1%
Files removed (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
-70.1KB +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
-68.24KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
-67.3KB +1%

Total files change -139.27KB -67.72%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codeclimate bot commented Dec 17, 2024

Code Climate has analyzed commit 8091e46 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4% (0.1% change).

View more on Code Climate.

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

@markwhitfeld markwhitfeld merged commit 35fea5c into master Dec 18, 2024
15 of 16 checks passed
@markwhitfeld markwhitfeld deleted the fix/2277 branch December 18, 2024 20:32
@Squixx
Copy link

Squixx commented Dec 19, 2024

Nice! Thanks for adding this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[BUG]: Actions triggered Twice
3 participants