-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(store): add root store initializer guard #2278
Conversation
In this commit, we are adding the root store initializer guard, which ensures that `provideStore()` is not accidentally called multiple times (e.g., in feature-level providers such as route providers).
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8091e46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
@ngxs/devtools-plugin
@ngxs/hmr-plugin
@ngxs/form-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +511B +0.39% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files added (1)
Files removed (3)
Total files change -139.27KB -67.72% Final result: ✅ View report in BundleMon website ➡️ |
Code Climate has analyzed commit 8091e46 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.1% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 LGTM
Nice! Thanks for adding this |
In this commit, we are adding the root store initializer guard, which ensures that
provideStore()
is not accidentally called multiple times (e.g., in feature-levelproviders such as route providers).