refactor(form-plugin): replace takeUntil with takeUntilDestroyed

[arturovt]

In this commit, we replace takeUntil with takeUntilDestroyed and remove ngOnDestroy
in favor of using DestroyRef.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit d2aa9a4.

Command	Status	Duration	Result
nx run-many --target=test --all --configuration...	✅ Succeeded	26s	View ↗
nx run-many --target=lint --all --exclude=creat...	✅ Succeeded	1s	View ↗
nx lint-types store	✅ Succeeded	<1s	View ↗
nx run-many --target=build --all	✅ Succeeded	2s	View ↗

---

☁️ Nx Cloud last updated this comment at 2024-12-22 20:18:01 UTC

[pkg-pr-new]

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2283

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2283

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2283

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2283

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2283

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2283

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2283

commit: d2aa9a4

[bundlemon]

BundleMon

Unchanged files (6)

Status	Path	Size	Limits
✅	fesm2022/ngxs-store.mjs	102.84KB	103KB / +0.5%
✅	fesm2022/ngxs-store-internals.mjs	11.51KB	13KB / +0.5%
✅	fesm2022/ngxs-store-internals-testing.mjs	6.8KB	7KB / +0.5%
✅	fesm2022/ngxs-store-operators.mjs	6.22KB	7KB / +0.5%
✅	fesm2022/ngxs-store-plugins.mjs	2.38KB	3KB / +0.5%
✅	fesm2022/ngxs-store-experimental.mjs	574B	2KB / +0.5%

No change in files bundle size

Unchanged groups (1)

Status	Path	Size	Limits
✅	@ngxs/store(fesm2022)[gzip] ./fesm2022/*.mjs	31.29KB	+1%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[bundlemon]

BundleMon (NGXS Plugins)

Files updated (1)

Status	Path	Size	Limits
❌	Plugins(fesm2022)[gzip] form-plugin/fesm2022/ngxs-form-plugin.mjs	2.46KB (+15B +0.6%)	+0.5%

Unchanged files (8)

Status	Path	Size	Limits
✅	Plugins(fesm2022)[gzip] storage-plugin/fesm2022/ngxs-storage-plugin.m js	4.03KB	+0.5%
✅	Plugins(fesm2022)[gzip] router-plugin/fesm2022/ngxs-router-plugin.mjs	3.01KB	+0.5%
✅	Plugins(fesm2022)[gzip] hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs	2.61KB	+0.5%
✅	Plugins(fesm2022)[gzip] websocket-plugin/fesm2022/ngxs-websocket-plug in.mjs	2.57KB	+0.5%
✅	Plugins(fesm2022)[gzip] devtools-plugin/fesm2022/ngxs-devtools-plugin .mjs	2.14KB	+0.5%
✅	Plugins(fesm2022)[gzip] logger-plugin/fesm2022/ngxs-logger-plugin.mjs	2.01KB	+0.5%
✅	Plugins(fesm2022)[gzip] storage-plugin/fesm2022/ngxs-storage-plugin-i nternals.mjs	861B	+0.5%
✅	Plugins(fesm2022)[gzip] router-plugin/fesm2022/ngxs-router-plugin-int ernals.mjs	396B	+0.5%

Total files change +15B +0.07%

Groups updated (1)

Status	Path	Size	Limits
✅	All Plugins(fesm2022)[gzip] ./-plugin/fesm2022/.mjs	20.05KB (+15B +0.07%)	+0.5%

Final result: ❌

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[bundlemon]

BundleMon (Integration Projects)

Files added (1)

Status	Path	Size	Limits
✅	Main bundles(Gzip) hello-world-ng19/dist-integration/browser/mai n-(hash).js	+66.38KB	+1%

Files removed (3)

Status	Path	Size	Limits
✅	Main bundles(Gzip) hello-world-ng18/dist-integration/browser/mai n-(hash).js	-70.1KB	+1%
✅	Main bundles(Gzip) hello-world-ng17/dist-integration/main.(hash) .js	-68.24KB	+1%
✅	Main bundles(Gzip) hello-world-ng16/dist-integration/main.(hash) .js	-67.3KB	+1%

Total files change -139.27KB -67.72%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[codeclimate]

Code Climate has analyzed commit d2aa9a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 94.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (-0.1% change).

View more on Code Climate.