fix(derived-async): fix unsubscribing from old observable when new value is not observable #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating this. Will check it in a bit. |
eneajaho
reviewed
Aug 21, 2024
MillerSvt
force-pushed
the
fix-unsubscribing-from-observable
branch
from
d6a4f0c
to
d937ade
Compare
…lue is not observable
MillerSvt
force-pushed
the
fix-unsubscribing-from-observable
branch
from
d937ade
to
71e84e9
Compare
|
@eneajaho Could you explain why the CI is not working? |
|
@MillerSvt just merge from main and CI should be working. Thank you for your contribution. |
|
@eneajaho can you re-review? |
|
@all-contributors please add @MillerSvt for code |
|
I've put up a pull request to add @MillerSvt! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.