refactor: Handle getting value from disabled form controls in form-events util
#499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase from latest |
|
The tests as well as a quick manual test of the test app seemed to work fine. I am terribad at git stuff that isn't commit/push/pull. Anything beyond those, like rebase. I may have screwed it up trying to just rebase following a guide. Idk if it doubling those commits up and the merge was intended from what I think I understand about rebases. I can try to revert this stuff, or is it fine as is? I'm pretty sure you are going to squash this anyways. edit: idk if this PR also being cosigned by my alt acct is a problem or not, but I am away from my main acct computer at the moment and wanted to get this change out |
…EventsObservable` Renaming of the functions outstanding beyond this issue. Addresses ngxtension#491 - Handle getting value from disabled form controls in `form-events` util
… case While I was making a test for fixing Issue ngxtension#491: Handle getting value from disabled form controls in form-events util, I realized the tests were misphrased, in that they didn't handle exactly what was said.
… as for single control
msmallest
force-pushed
the
refactor/getRawValue-form-events
branch
from
6eb5e0a
to
fcd218e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
In all my efforts to get this util all together, I overlooked one of the most important things when it comes to getting form values from reactive forms (for what I argue in the issue is what most people want): getting the value of the form and each control even if the form is disabled.
Closes #491: "Handle getting value from disabled form controls in
form-eventsutil"Notes
form-eventsand its functions is outstanding.toFormState? I feel like it is the compliment to the proposed observable util name offromFormEvents.