Merge pull request #1959 from fredericDelaporte/QuerySpaceDml

Backport Query space invalidation doesn't work for bulk actions

appveyor.yml

@@ -1,4 +1,4 @@
-version: 5.1.3.{build}
+version: 5.1.4.{build}
 image: Visual Studio 2017
 environment:
   matrix:

build-common/NHibernate.props

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <VersionMajor Condition="'$(VersionMajor)' == ''">5</VersionMajor>
     <VersionMinor Condition="'$(VersionMinor)' == ''">1</VersionMinor>
-    <VersionPatch Condition="'$(VersionPatch)' == ''">3</VersionPatch>
+    <VersionPatch Condition="'$(VersionPatch)' == ''">4</VersionPatch>
     <VersionSuffix Condition="'$(VersionSuffix)' == ''"></VersionSuffix>
 
     <VersionPrefix>$(VersionMajor).$(VersionMinor).$(VersionPatch)</VersionPrefix>

build-common/common.xml

@@ -13,8 +13,8 @@
 
 	<!-- This is used only for build folder -->
 	<!-- TODO: Either remove or refactor to use NHibernate.props -->
-	<property name="project.version" value="5.1.3" overwrite="false" />
-	<property name="project.version.numeric" value="5.1.3" overwrite="false" />
+	<property name="project.version" value="5.1.4" overwrite="false" />
+	<property name="project.version.numeric" value="5.1.4" overwrite="false" />
 
 	<!-- properties used to connect to database for testing -->
 	<include buildfile="nhibernate-properties.xml" />

releasenotes.txt

@@ -1,3 +1,12 @@
+Build 5.1.4
+=============================
+
+Release notes - NHibernate - Version 5.1.4
+
+** Bug
+
+   * #1959 Backport Query space invalidation doesn't work for bulk actions
+
 Build 5.1.3
 =============================
 

src/NHibernate.Test/Async/SecondLevelCacheTest/InvalidationTests.cs

@@ -15,6 +15,7 @@
 using NHibernate.Cache;
 using NHibernate.Cfg;
 using NHibernate.Impl;
+using NHibernate.Linq;
 using NHibernate.Test.SecondLevelCacheTests;
 using NSubstitute;
 using NUnit.Framework;
@@ -59,6 +60,7 @@ public async Task InvalidatesEntitiesAsync()
 
 			using (var session = OpenSession())
 			{
+				//Add Item
 				using (var tx = session.BeginTransaction())
 				{
 					foreach (var i in Enumerable.Range(1, 10))
@@ -70,6 +72,7 @@ public async Task InvalidatesEntitiesAsync()
 					await (tx.CommitAsync());
 				}
 
+				//Update Item
 				using (var tx = session.BeginTransaction())
 				{
 					foreach (var i in Enumerable.Range(1, 10))
@@ -81,6 +84,7 @@ public async Task InvalidatesEntitiesAsync()
 					await (tx.CommitAsync());
 				}
 
+				//Delete Item
 				using (var tx = session.BeginTransaction())
 				{
 					foreach (var i in Enumerable.Range(1, 10))
@@ -91,14 +95,44 @@ public async Task InvalidatesEntitiesAsync()
 
 					await (tx.CommitAsync());
 				}
+
+				//Update Item using HQL
+				using (var tx = session.BeginTransaction())
+				{
+					await (session.CreateQuery("UPDATE Item SET Name='Test'").ExecuteUpdateAsync());
+
+					await (tx.CommitAsync());
+				}
+
+
+				//Update Item using LINQ
+				using (var tx = session.BeginTransaction())
+				{
+					await (session.Query<Item>()
+					       .UpdateBuilder()
+					       .Set(x => x.Name, "Test")
+					       .UpdateAsync(CancellationToken.None));
+
+					await (tx.CommitAsync());
+				}
+
+				//Update Item using SQL
+				using (var tx = session.BeginTransaction())
+				{
+					await (session.CreateSQLQuery("UPDATE Item SET Name='Test'")
+					       .ExecuteUpdateAsync());
+
+					await (tx.CommitAsync());
+				}
 			}
 
-			//Should receive one preinvalidation and one invalidation per commit
+			//Should receive one preinvalidation per non-DML commit
 			Assert.That(preInvalidations, Has.Count.EqualTo(3));
 			Assert.That(preInvalidations, Has.All.Count.EqualTo(1).And.Contains("Item"));
 
-			Assert.That(invalidations, Has.Count.EqualTo(3));
-			Assert.That(invalidations, Has.All.Count.EqualTo(1).And.Contains("Item"));
+			///...and one invalidation per commit
+			Assert.That(invalidations, Has.Count.EqualTo(6));
+			Assert.That(invalidations, Has.All.Contains("Item"));
 		}
 
 		protected override void OnTearDown()

src/NHibernate.Test/SecondLevelCacheTest/InvalidationTests.cs

@@ -5,6 +5,7 @@
 using NHibernate.Cache;
 using NHibernate.Cfg;
 using NHibernate.Impl;
+using NHibernate.Linq;
 using NHibernate.Test.SecondLevelCacheTests;
 using NSubstitute;
 using NUnit.Framework;
@@ -47,6 +48,7 @@ public void InvalidatesEntities()
 
 			using (var session = OpenSession())
 			{
+				//Add Item
 				using (var tx = session.BeginTransaction())
 				{
 					foreach (var i in Enumerable.Range(1, 10))
@@ -58,6 +60,7 @@ public void InvalidatesEntities()
 					tx.Commit();
 				}
 
+				//Update Item
 				using (var tx = session.BeginTransaction())
 				{
 					foreach (var i in Enumerable.Range(1, 10))
@@ -69,6 +72,7 @@ public void InvalidatesEntities()
 					tx.Commit();
 				}
 
+				//Delete Item
 				using (var tx = session.BeginTransaction())
 				{
 					foreach (var i in Enumerable.Range(1, 10))
@@ -79,14 +83,44 @@ public void InvalidatesEntities()
 
 					tx.Commit();
 				}
+
+				//Update Item using HQL
+				using (var tx = session.BeginTransaction())
+				{
+					session.CreateQuery("UPDATE Item SET Name='Test'").ExecuteUpdate();
+
+					tx.Commit();
+				}
+
+
+				//Update Item using LINQ
+				using (var tx = session.BeginTransaction())
+				{
+					session.Query<Item>()
+					       .UpdateBuilder()
+					       .Set(x => x.Name, "Test")
+					       .Update();
+
+					tx.Commit();
+				}
+
+				//Update Item using SQL
+				using (var tx = session.BeginTransaction())
+				{
+					session.CreateSQLQuery("UPDATE Item SET Name='Test'")
+					       .ExecuteUpdate();
+
+					tx.Commit();
+				}
 			}
 
-			//Should receive one preinvalidation and one invalidation per commit
+			//Should receive one preinvalidation per non-DML commit
 			Assert.That(preInvalidations, Has.Count.EqualTo(3));
 			Assert.That(preInvalidations, Has.All.Count.EqualTo(1).And.Contains("Item"));
 
-			Assert.That(invalidations, Has.Count.EqualTo(3));
-			Assert.That(invalidations, Has.All.Count.EqualTo(1).And.Contains("Item"));
+			///...and one invalidation per commit
+			Assert.That(invalidations, Has.Count.EqualTo(6));
+			Assert.That(invalidations, Has.All.Contains("Item"));
 		}
 
 		protected override void OnTearDown()

src/NHibernate/Async/Engine/ActionQueue.cs

@@ -82,10 +82,6 @@ private async Task InnerExecuteAsync(IExecutable executable, CancellationToken c
 			}
 			finally
 			{
-				if (executable.PropertySpaces != null)
-				{
-					executedSpaces.UnionWith(executable.PropertySpaces);
-				}
 				RegisterCleanupActions(executable);
 			}
 		}

src/NHibernate/Engine/ActionQueue.cs

@@ -185,10 +185,6 @@ private void InnerExecute(IExecutable executable)
 			}
 			finally
 			{
-				if (executable.PropertySpaces != null)
-				{
-					executedSpaces.UnionWith(executable.PropertySpaces);
-				}
 				RegisterCleanupActions(executable);
 			}
 		}
@@ -197,6 +193,10 @@ private void RegisterCleanupActions(IExecutable executable)
 		{
 			beforeTransactionProcesses.Register(executable.BeforeTransactionCompletionProcess);
 			afterTransactionProcesses.Register(executable.AfterTransactionCompletionProcess);
+			if (executable.PropertySpaces != null)
+			{
+				executedSpaces.UnionWith(executable.PropertySpaces);
+			}
 		}
 
 		/// <summary>