fix: left/right key works wrong around hr (fix: 543) #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2019 20:04
So hr should be wrapped by div that has contenteditable as false.
shiren
reviewed
Jun 19, 2019
src/js/wwHrManager.js
Outdated
| * @memberof WwHrManager | ||
| * @private | ||
| */ | ||
| _unwrapDivOnHr() { | ||
| _changeHRContenteditableFalse() { |
There was a problem hiding this comment.
contenteditable을 false로 바꾸는건 domUtils.createHorizontalRule가 하니까 이 메서드의 이름은 한 뎊스 더 추상화된 이름이 되어야할것 같아요..contenteditable을 false로 두는게 해결방법이 아니라 다른 방법으로 바뀌어도 이메서드의 이름은 수정할 필요가 없게 말이죠.
junghwan-park
approved these changes
Jun 19, 2019
kishorethecoder
pushed a commit
to kishorethecoder/tui.editor
that referenced
this pull request
Jul 11, 2019
* fix: left/right key works wrong around hr So hr should be wrapped by div that has contenteditable as false. * chore: squire update for contenteditable=false * refactor: reflect code review
kishorethecoder
added a commit
to kishorethecoder/tui.editor
that referenced
this pull request
Dec 4, 2019
This reverts commit 7204d2e.
kishorethecoder
added a commit
to kishorethecoder/tui.editor
that referenced
this pull request
Dec 4, 2019
This reverts commit 7204d2e.
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 2, 2020
* fix: left/right key works wrong around hr So hr should be wrapped by div that has contenteditable as false. * chore: squire update for contenteditable=false * refactor: reflect code review
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 6, 2020
* fix: left/right key works wrong around hr So hr should be wrapped by div that has contenteditable as false. * chore: squire update for contenteditable=false * refactor: reflect code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
fix: #543
구분선 주변에서 좌우 키로 이동 시 커서(range)가
<hr>테그 양옆에 위치하게 되고 (실제 랜더링은 css의 영향으로<hr>바로 아래에 렌더링 된다.) 그 순간 텍스트를 입력하면 구분선 위아래에 텍스트가 입력됩니다.이를 수정하기 위해 구분선을 아래와 같은 형태의 돔으로 운영하도록 변경하였습니다.
추가로 스콰이어에 의해서 보통의 텍스트를 나타내는
<div>가<div contenteditable="false">로 머지될 소지가 있으며, delete키와 backspace 키로 구분선을 지울 때<div contenteditable="false">안에 있는<hr contenteditable="false">만 지우는 문제가 있는데, 이는 스콰이어 쪽에서contenteditable="false"에 대해 예외처리하도록 수정하였습니다. (sohee-lee7/Squire#7)Thank you for your contribution to TOAST UI product. 🎉 😘 ✨