Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: look for projects in organizations #927

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: look for projects in organizations #927

merged 2 commits into from
Dec 4, 2024

Conversation

dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Dec 4, 2024

PR Type

bug_fix


Description

  • Fixed the app lookup logic to include searching within organizations, not just workspaces.
  • Renamed a variable for better clarity in the code.
  • Improved error handling by providing a more descriptive error message when an app is not found.

Changes walkthrough 📝

Relevant files
Bug fix
wf_app_info.go
Fix and enhance app lookup in organizations and workspaces

clienv/wf_app_info.go

  • Changed the variable name from workspaces to resp for clarity.
  • Added logic to iterate over Organizations to find apps by subdomain.
  • Enhanced error message for failed app lookup by subdomain.
  • +10/-2   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @github-actions github-actions bot added the fix label Dec 4, 2024
    Copy link
    Contributor

    github-actions bot commented Dec 4, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Error Handling
    The error message when failing to get organizations and workspaces is still generic. Consider providing more context or details in the error message to help with debugging.

    Copy link
    Contributor

    github-actions bot commented Dec 4, 2024

    PR Code Suggestions ✨

    @dbarrosop dbarrosop merged commit 21bef1c into main Dec 4, 2024
    8 checks passed
    @dbarrosop dbarrosop deleted the orgs branch December 4, 2024 14:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants