Add FullNameConcern

This is a concern which handles the displaying of a full name combined
from a given name and a family name.

app/controllers/cohorts_controller.rb

@@ -29,13 +29,7 @@ def index
   def show
     @cohort = policy_scope(Cohort).find(params[:id])
     @pagy, @patients =
-      pagy(
-        @cohort
-          .patients
-          .recorded
-          .includes(:school)
-          .order(:given_name, :family_name)
-      )
+      pagy(@cohort.patients.recorded.includes(:school).order_by_name)
   end
 
   private

app/controllers/concerns/full_name_concern.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module FullNameConcern
+  extend ActiveSupport::Concern
+
+  included { scope :order_by_name, -> { order(:given_name, :family_name) } }
+
+  def full_name
+    "#{given_name} #{family_name}"
+  end
+end

app/models/consent_form.rb

@@ -59,6 +59,7 @@
 class ConsentForm < ApplicationRecord
   include AddressConcern
   include AgeConcern
+  include FullNameConcern
   include WizardStepConcern
 
   before_save :reset_unused_fields
@@ -240,10 +241,6 @@ class ConsentForm < ApplicationRecord
 
   delegate :vaccines, to: :programme
 
-  def full_name
-    [given_name, family_name].join(" ")
-  end
-
   def wizard_steps
     [
       :name,

app/models/patient.rb

@@ -37,6 +37,7 @@
 class Patient < ApplicationRecord
   include AddressConcern
   include AgeConcern
+  include FullNameConcern
   include PendingChangesConcern
   include Recordable
 
@@ -128,10 +129,6 @@ def relationship_to(parent:)
     parent_relationships.find { _1.parent == parent }
   end
 
-  def full_name
-    "#{given_name} #{family_name}"
-  end
-
   def year_group
     cohort&.year_group || date_of_birth.year_group
   end

app/models/user.rb

@@ -26,6 +26,8 @@
 #  index_users_on_provider_and_uid  (provider,uid) UNIQUE
 #
 class User < ApplicationRecord
+  include FullNameConcern
+
   devise :database_authenticatable,
          :trackable,
          :timeoutable,
@@ -60,10 +62,6 @@ class User < ApplicationRecord
   scope :recently_active,
         -> { where(last_sign_in_at: 1.week.ago..Time.current) }
 
-  def full_name
-    [given_name, family_name].join(" ")
-  end
-
   def team
     # TODO: Update the app to properly support multiple teams per user
     teams.first