Remove .all from ConsentForm find_each migrations

It shouldn't be necessary.
nhsuk · Oct 16, 2024 · 48a71a0 · 48a71a0
1 parent 2b29f0c
commit 48a71a0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/db/migrate/20240924112619_add_programme_to_consent_forms.rb b/db/migrate/20240924112619_add_programme_to_consent_forms.rb
@@ -4,7 +4,7 @@ class AddProgrammeToConsentForms < ActiveRecord::Migration[7.2]
   def up
     add_reference :consent_forms, :programme, foreign_key: true
 
-    ConsentForm.all.find_each do |consent_form|
+    ConsentForm.find_each do |consent_form|
       consent_form.update!(
         programme_id: (consent_form.session.programme || Programme.first).id
       )

diff --git a/db/migrate/20241002125816_add_team_to_consent_forms.rb b/db/migrate/20241002125816_add_team_to_consent_forms.rb
@@ -4,7 +4,7 @@ class AddTeamToConsentForms < ActiveRecord::Migration[7.2]
   def up
     add_reference :consent_forms, :team, foreign_key: true
 
-    ConsentForm.all.find_each do |consent_form|
+    ConsentForm.find_each do |consent_form|
       consent_form.update!(team_id: consent_form.session.team_id)
     end
 

diff --git a/db/migrate/20241002130716_add_school_to_consent_forms.rb b/db/migrate/20241002130716_add_school_to_consent_forms.rb
@@ -4,7 +4,7 @@ class AddSchoolToConsentForms < ActiveRecord::Migration[7.2]
   def up
     add_reference :consent_forms, :school, foreign_key: { to_table: :locations }
 
-    ConsentForm.all.find_each do |consent_form|
+    ConsentForm.find_each do |consent_form|
       consent_form.update!(location_id: consent_form.session.team_id)
     end