-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back links and breadcrumbs tweaks #1002
Commits on Jun 10, 2024
-
The back link should be added to the template at the start of the `<div class="nhsuk-width-container">` container but before the `<main>` container. This is to ensure that it gets skipped over when using the "skip to main content" link. However currently the back link by default will appear too close to the header and too far away from the h1. This adjusts the spacing to add some spacing before the back link, but no spacing after it (as the `<main>` element already add enough vertical spacing at the top using padding).
Configuration menu - View commit details
-
Copy full SHA for 920e844 - Browse repository at this point
Copy the full SHA 920e844View commit details -
The back link should appear before the `<main>` element. Also added an example `<h1>` within the `<main>` element to more clearly illustration the relationship between the 2 elements.
Configuration menu - View commit details
-
Copy full SHA for 1a278b5 - Browse repository at this point
Copy the full SHA 1a278b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37533ac - Browse repository at this point
Copy the full SHA 37533acView commit details
Commits on Jun 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e062b5 - Browse repository at this point
Copy the full SHA 0e062b5View commit details
Commits on Jun 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 99222f6 - Browse repository at this point
Copy the full SHA 99222f6View commit details
Commits on Jun 21, 2024
-
Move breadcrumb inside nhsuk-width-container
Currently in the examples there’s a `breadcrumb` block which is outside the `<div class="nhsuk-width-container">`, in a similar way to the `beforeContent` block in the template in the NHS design system. This moves the breadcrumb into `<div class="nhsuk-width-container">`, but before `<main class="nhsuk-main-wrapper" id="maincontent">`, by defining a `outerContent` which matches the existing NHS design system template.
Configuration menu - View commit details
-
Copy full SHA for 9ddebc1 - Browse repository at this point
Copy the full SHA 9ddebc1View commit details -
Remove .nhsuk-width-container from breadcrumb
This is no longer needed if the breadcrumb component itself is already inside the nhs-width-container.
Configuration menu - View commit details
-
Copy full SHA for 1ecbedd - Browse repository at this point
Copy the full SHA 1ecbeddView commit details -
Update breadcrumb to use margins instead of padding
This is for consistency with the Back link component.
Configuration menu - View commit details
-
Copy full SHA for 22c78f1 - Browse repository at this point
Copy the full SHA 22c78f1View commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e3a266f - Browse repository at this point
Copy the full SHA e3a266fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ca27f3 - Browse repository at this point
Copy the full SHA 4ca27f3View commit details
Commits on Jul 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3b25424 - Browse repository at this point
Copy the full SHA 3b25424View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7e68b40 - Browse repository at this point
Copy the full SHA 7e68b40View commit details
Commits on Aug 28, 2024
-
Merge branch 'main' of https://github.com/nhsuk/nhsuk-frontend into m…
…ove-breadcrumb-inside-width-container
Configuration menu - View commit details
-
Copy full SHA for 9b0eb9c - Browse repository at this point
Copy the full SHA 9b0eb9cView commit details -
Merge branch 'adjust-spacing-for-back-link' of https://github.com/nhs…
…uk/nhsuk-frontend into release-testing
Configuration menu - View commit details
-
Copy full SHA for 63342c9 - Browse repository at this point
Copy the full SHA 63342c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6caacf - Browse repository at this point
Copy the full SHA b6caacfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 396ff95 - Browse repository at this point
Copy the full SHA 396ff95View commit details -
remove underline on breadcrumb back link, to match back link. Plus sp…
…acing tweaks for mobile
Configuration menu - View commit details
-
Copy full SHA for 125fc92 - Browse repository at this point
Copy the full SHA 125fc92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a74acf - Browse repository at this point
Copy the full SHA 0a74acfView commit details -
Rename outerContent as beforeContent
This brings us into alignment with GOV.UK Frontend naming conventions. The named `outerContent` block would no longer be needed.
Configuration menu - View commit details
-
Copy full SHA for bb1b715 - Browse repository at this point
Copy the full SHA bb1b715View commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 219b1e8 - Browse repository at this point
Copy the full SHA 219b1e8View commit details
Commits on Aug 30, 2024
-
This saves having to re-define the `<main>` element and demonstrates use of the `beforeContent` block.
Configuration menu - View commit details
-
Copy full SHA for 99775bf - Browse repository at this point
Copy the full SHA 99775bfView commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9568dce - Browse repository at this point
Copy the full SHA 9568dceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee6c1c - Browse repository at this point
Copy the full SHA 7ee6c1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9b9e97 - Browse repository at this point
Copy the full SHA f9b9e97View commit details