Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back links and breadcrumbs tweaks #1002

Merged
merged 24 commits into from
Sep 10, 2024
Merged

Commits on Jun 10, 2024

  1. Adjust spacing for back link

    The back link should be added to the template at the start of the `<div class="nhsuk-width-container">` container but before the `<main>` container. This is to ensure that it gets skipped over when using the "skip to main content" link.
    
    However currently the back link by default will appear too close to the header and too far away from the h1. This adjusts the spacing to add some spacing before the back link, but no spacing after it (as the `<main>` element already add enough vertical spacing at the top using padding).
    frankieroberto committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    920e844 View commit details
    Browse the repository at this point in the history
  2. Update back link examples

    The back link should appear before the `<main>` element. Also added an example `<h1>` within the `<main>` element to more clearly illustration the relationship between the 2 elements.
    frankieroberto committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1a278b5 View commit details
    Browse the repository at this point in the history
  3. Update changelog

    frankieroberto committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    37533ac View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    0e062b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Configuration menu
    Copy the full SHA
    99222f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Move breadcrumb inside nhsuk-width-container

    Currently in the examples there’s a `breadcrumb` block which is outside the `<div class="nhsuk-width-container">`, in a similar way to the `beforeContent` block in the template in the NHS design system.
    
    This moves the breadcrumb into `<div class="nhsuk-width-container">`, but before `<main class="nhsuk-main-wrapper" id="maincontent">`, by defining a `outerContent` which matches the existing NHS design system template.
    frankieroberto committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9ddebc1 View commit details
    Browse the repository at this point in the history
  2. Remove .nhsuk-width-container from breadcrumb

    This is no longer needed if the breadcrumb component itself is already inside the nhs-width-container.
    frankieroberto committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1ecbedd View commit details
    Browse the repository at this point in the history
  3. Update breadcrumb to use margins instead of padding

    This is for consistency with the Back link component.
    frankieroberto committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    22c78f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    e3a266f View commit details
    Browse the repository at this point in the history
  2. Fix changelog style

    frankieroberto committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4ca27f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    3b25424 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    7e68b40 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'main' of https://github.com/nhsuk/nhsuk-frontend into m…

    …ove-breadcrumb-inside-width-container
    anandamaryon1 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9b0eb9c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63342c9 View commit details
    Browse the repository at this point in the history
  3. merge

    anandamaryon1 committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b6caacf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    396ff95 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    125fc92 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0a74acf View commit details
    Browse the repository at this point in the history
  7. Rename outerContent as beforeContent

    This brings us into alignment with GOV.UK Frontend naming conventions.
    
    The named `outerContent` block would no longer be needed.
    frankieroberto committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    bb1b715 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. update reference images

    roshaanbajwa committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    219b1e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Use page template in examples

    This saves having to re-define the `<main>` element and demonstrates use of the `beforeContent` block.
    frankieroberto committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    99775bf View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    9568dce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ee6c1c View commit details
    Browse the repository at this point in the history
  3. backstop refs

    anandamaryon1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f9b9e97 View commit details
    Browse the repository at this point in the history