Update error summary markup to improve screen reader announcements #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had a look and the update does fix the issue of VoiceOver on Mac Safari not reading out the error summary title twice. However, on NVDA, the summary title ("This is a problem" in the examples below) is not initially read our when compared to the current version. Tested on NVDA v2024.3.1 on Windows 10. Current: With update: @edwardhorsford - could you confirm this is the case and also whether this is a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1035.
This replicates this GOV.UK Frontend pr.
The issue I was having was 'There is a problem' getting read out twice. That's not mentioned in the GDS pr, but does seem to be fixed in making these improvements.
I don't think this is a breaking change (GDS didn't release it as one), but it does update the markup.
Checklist