Use fallback font if not including NHS font face #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a configuration option `$nhsuk-include-font-face` which controls if the NHS corporate font is included in the compiled CSS. In the current implementation, if this option is false then `font-face` is not set at all, which leads to unstyled text. This change makes it so that if the fonts are not included, a `font-face` declaration is still made using only the fallback fonts (as set in `$nhsuk-font-fallback`).
Use fallback font if not including NHS font face
|
Not passing judgement on this either negatively or positively, but just wanted to link to this pull request which has some background to why it is like it is right now, i.e. mimicing the way it works in govuk-frontend. And to note that whatever path is taken here needs to be compatible with the needs from this thread - where someone is self hosting the nhs fonts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a configuration option
$nhsuk-include-font-facewhich controls if the NHS corporate font is included in the compiled CSS. In the current implementation, if this option is false thenfont-faceis not set at all, which leads to unstyled text.This change makes it so that if the fonts are not included, a
font-facedeclaration is still made using only the fallback fonts (as set in$nhsuk-font-fallback).Checklist