nhsuk · roshaanbajwa · Jul 10, 2024 · Jun 6, 2024 · Jun 6, 2024 · Jun 6, 2024
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -10,6 +10,11 @@ jobs:
     steps:
     - uses: actions/checkout@v2
 
+    - uses: actions/setup-node@v1
+      with:
+        node-version: 20
+        registry-url: https://registry.npmjs.org/
+
     - name: Install dependencies
       run: npm install
 

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -17,7 +17,7 @@ jobs:
 
       - uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: 20
           registry-url: https://registry.npmjs.org/
 
       - name: Install dependencies

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16
+20
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -28,19 +28,19 @@
     "jest:ci": "jest"
   },
   "devDependencies": {
-    "@babel/core": "^7.18.6",
-    "@babel/eslint-parser": "^7.18.9",
-    "@babel/preset-env": "^7.18.6",
-    "babel-loader": "^8.2.5",
-    "backstopjs": "^6.1.0",
-    "concurrently": "^7.2.2",
+    "@babel/core": "^7.24.7",
+    "@babel/eslint-parser": "^7.24.7",
+    "@babel/preset-env": "^7.24.7",
+    "babel-loader": "^9.1.3",
+    "backstopjs": "^6.3.23",
+    "concurrently": "^8.2.2",
     "eslint": "^8.19.0",
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-postcss": "^4.0.0",
-    "eslint-config-prettier": "^8.5.0",
+    "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-prettier": "^4.2.1",
     "follow-redirects": "^1.15.6",
-    "gulp": "^4.0.2",
+    "gulp": "^5.0.0",
     "gulp-clean": "^0.4.0",
     "gulp-clean-css": "^4.3.0",
     "gulp-connect": "^5.7.0",
@@ -50,21 +50,21 @@
     "gulp-uglify": "^3.0.2",
     "gulp-zip": "^5.1.0",
     "htmlhint": "^1.1.4",
-    "husky": "^8.0.1",
-    "jest": "^28.1.3",
-    "jest-environment-jsdom": "^28.1.3",
-    "jest-environment-puppeteer": "^7.0.0",
-    "minimist": "^1.2.6",
-    "nunjucks": "^3.2.3",
+    "husky": "^9.0.11",
+    "jest": "^29.7.0",
+    "jest-environment-jsdom": "^29.7.0",
+    "jest-environment-puppeteer": "^10.0.1",
+    "minimist": "^1.2.8",
+    "nunjucks": "^3.2.4",
     "prettier": "^2.7.1",
     "puppeteer": "^18.1.0",
-    "sass": "^1.53.0",
-    "start-server-and-test": "^1.14.0",
+    "sass": "^1.77.4",
+    "start-server-and-test": "^2.0.4",
     "stylelint": "^13.13.1",
-    "stylelint-config-prettier": "^9.0.3",
+    "stylelint-config-prettier": "^9.0.5",
     "stylelint-order": "^4.1.0",
-    "stylelint-scss": "^3.19.0",
-    "wait-on": "^6.0.1",
+    "stylelint-scss": "^3.21.0",
+    "wait-on": "^7.2.0",
     "webpack-stream": "^7.0.0"
   },
   "publishConfig": {

diff --git a/...nhsuk-frontend_Checkboxes_with_conditional_content_0_document_0_iPhone_5_SE.png b/...nhsuk-frontend_Checkboxes_with_conditional_content_0_document_0_iPhone_5_SE.png
diff --git a/.../nhsuk-frontend_Checkboxes_with_conditional_content_0_document_1_iPhone_6-8.png b/.../nhsuk-frontend_Checkboxes_with_conditional_content_0_document_1_iPhone_6-8.png
diff --git a/...erence/nhsuk-frontend_Checkboxes_with_conditional_content_0_document_2_iPad.png b/...erence/nhsuk-frontend_Checkboxes_with_conditional_content_0_document_2_iPad.png
diff --git a/...-frontend_Checkboxes_with_conditional_content_0_document_3_Surface_iPad_Pro.png b/...-frontend_Checkboxes_with_conditional_content_0_document_3_Surface_iPad_Pro.png
diff --git a/...k-frontend_Checkboxes_with_error_message_-_focused_0_document_0_iPhone_5_SE.png b/...k-frontend_Checkboxes_with_error_message_-_focused_0_document_0_iPhone_5_SE.png
diff --git a/...uk-frontend_Checkboxes_with_error_message_-_focused_0_document_1_iPhone_6-8.png b/...uk-frontend_Checkboxes_with_error_message_-_focused_0_document_1_iPhone_6-8.png
diff --git a/...ce/nhsuk-frontend_Checkboxes_with_error_message_-_focused_0_document_2_iPad.png b/...ce/nhsuk-frontend_Checkboxes_with_error_message_-_focused_0_document_2_iPad.png
diff --git a/...ntend_Checkboxes_with_error_message_-_focused_0_document_3_Surface_iPad_Pro.png b/...ntend_Checkboxes_with_error_message_-_focused_0_document_3_Surface_iPad_Pro.png
diff --git a/.../backstop/bitmaps_reference/nhsuk-frontend_Details_0_document_0_iPhone_5_SE.png b/.../backstop/bitmaps_reference/nhsuk-frontend_Details_0_document_0_iPhone_5_SE.png
diff --git a/...s/backstop/bitmaps_reference/nhsuk-frontend_Details_0_document_1_iPhone_6-8.png b/...s/backstop/bitmaps_reference/nhsuk-frontend_Details_0_document_1_iPhone_6-8.png
diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Details_0_document_2_iPad.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Details_0_document_2_iPad.png
diff --git a/...stop/bitmaps_reference/nhsuk-frontend_Details_0_document_3_Surface_iPad_Pro.png b/...stop/bitmaps_reference/nhsuk-frontend_Details_0_document_3_Surface_iPad_Pro.png
diff --git a/...backstop/bitmaps_reference/nhsuk-frontend_Expander_0_document_0_iPhone_5_SE.png b/...backstop/bitmaps_reference/nhsuk-frontend_Expander_0_document_0_iPhone_5_SE.png
diff --git a/.../backstop/bitmaps_reference/nhsuk-frontend_Expander_0_document_1_iPhone_6-8.png b/.../backstop/bitmaps_reference/nhsuk-frontend_Expander_0_document_1_iPhone_6-8.png
diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Expander_0_document_2_iPad.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Expander_0_document_2_iPad.png
diff --git a/...top/bitmaps_reference/nhsuk-frontend_Expander_0_document_3_Surface_iPad_Pro.png b/...top/bitmaps_reference/nhsuk-frontend_Expander_0_document_3_Surface_iPad_Pro.png
diff --git a/...op/bitmaps_reference/nhsuk-frontend_Expander_group_0_document_0_iPhone_5_SE.png b/...op/bitmaps_reference/nhsuk-frontend_Expander_group_0_document_0_iPhone_5_SE.png
diff --git a/...top/bitmaps_reference/nhsuk-frontend_Expander_group_0_document_1_iPhone_6-8.png b/...top/bitmaps_reference/nhsuk-frontend_Expander_group_0_document_1_iPhone_6-8.png
diff --git a/.../backstop/bitmaps_reference/nhsuk-frontend_Expander_group_0_document_2_iPad.png b/.../backstop/bitmaps_reference/nhsuk-frontend_Expander_group_0_document_2_iPad.png
diff --git a/...tmaps_reference/nhsuk-frontend_Expander_group_0_document_3_Surface_iPad_Pro.png b/...tmaps_reference/nhsuk-frontend_Expander_group_0_document_3_Surface_iPad_Pro.png
diff --git a/...ference/nhsuk-frontend_Header_with_navigation_open_0_document_0_iPhone_5_SE.png b/...ference/nhsuk-frontend_Header_with_navigation_open_0_document_0_iPhone_5_SE.png
diff --git a/...eference/nhsuk-frontend_Header_with_navigation_open_0_document_1_iPhone_6-8.png b/...eference/nhsuk-frontend_Header_with_navigation_open_0_document_1_iPhone_6-8.png
diff --git a/...maps_reference/nhsuk-frontend_Header_with_navigation_open_0_document_2_iPad.png b/...maps_reference/nhsuk-frontend_Header_with_navigation_open_0_document_2_iPad.png
diff --git a/.../nhsuk-frontend_Input_with_error_message_-_focused_0_document_0_iPhone_5_SE.png b/.../nhsuk-frontend_Input_with_error_message_-_focused_0_document_0_iPhone_5_SE.png
diff --git a/...e/nhsuk-frontend_Input_with_error_message_-_focused_0_document_1_iPhone_6-8.png b/...e/nhsuk-frontend_Input_with_error_message_-_focused_0_document_1_iPhone_6-8.png
diff --git a/...ference/nhsuk-frontend_Input_with_error_message_-_focused_0_document_2_iPad.png b/...ference/nhsuk-frontend_Input_with_error_message_-_focused_0_document_2_iPad.png
diff --git a/...k-frontend_Input_with_error_message_-_focused_0_document_3_Surface_iPad_Pro.png b/...k-frontend_Input_with_error_message_-_focused_0_document_3_Surface_iPad_Pro.png
diff --git a/...nce/nhsuk-frontend_Radios_with_conditional_content_0_document_0_iPhone_5_SE.png b/...nce/nhsuk-frontend_Radios_with_conditional_content_0_document_0_iPhone_5_SE.png
diff --git a/...ence/nhsuk-frontend_Radios_with_conditional_content_0_document_1_iPhone_6-8.png b/...ence/nhsuk-frontend_Radios_with_conditional_content_0_document_1_iPhone_6-8.png
diff --git a/..._reference/nhsuk-frontend_Radios_with_conditional_content_0_document_2_iPad.png b/..._reference/nhsuk-frontend_Radios_with_conditional_content_0_document_2_iPad.png
diff --git a/...hsuk-frontend_Radios_with_conditional_content_0_document_3_Surface_iPad_Pro.png b/...hsuk-frontend_Radios_with_conditional_content_0_document_3_Surface_iPad_Pro.png
diff --git a/..._Radios_with_hint_text_and_error_message_-_focused_0_document_0_iPhone_5_SE.png b/..._Radios_with_hint_text_and_error_message_-_focused_0_document_0_iPhone_5_SE.png
diff --git a/...d_Radios_with_hint_text_and_error_message_-_focused_0_document_1_iPhone_6-8.png b/...d_Radios_with_hint_text_and_error_message_-_focused_0_document_1_iPhone_6-8.png
diff --git a/...rontend_Radios_with_hint_text_and_error_message_-_focused_0_document_2_iPad.png b/...rontend_Radios_with_hint_text_and_error_message_-_focused_0_document_2_iPad.png
diff --git a/...os_with_hint_text_and_error_message_-_focused_0_document_3_Surface_iPad_Pro.png b/...os_with_hint_text_and_error_message_-_focused_0_document_3_Surface_iPad_Pro.png
diff --git a/..._Select_with_hint_text_and_error_message_-_focused_0_document_0_iPhone_5_SE.png b/..._Select_with_hint_text_and_error_message_-_focused_0_document_0_iPhone_5_SE.png
diff --git a/...d_Select_with_hint_text_and_error_message_-_focused_0_document_1_iPhone_6-8.png b/...d_Select_with_hint_text_and_error_message_-_focused_0_document_1_iPhone_6-8.png
diff --git a/...rontend_Select_with_hint_text_and_error_message_-_focused_0_document_2_iPad.png b/...rontend_Select_with_hint_text_and_error_message_-_focused_0_document_2_iPad.png
diff --git a/...ct_with_hint_text_and_error_message_-_focused_0_document_3_Surface_iPad_Pro.png b/...ct_with_hint_text_and_error_message_-_focused_0_document_3_Surface_iPad_Pro.png
diff --git a/...suk-frontend_Textarea_with_error_message_-_focused_0_document_0_iPhone_5_SE.png b/...suk-frontend_Textarea_with_error_message_-_focused_0_document_0_iPhone_5_SE.png
diff --git a/...hsuk-frontend_Textarea_with_error_message_-_focused_0_document_1_iPhone_6-8.png b/...hsuk-frontend_Textarea_with_error_message_-_focused_0_document_1_iPhone_6-8.png
diff --git a/...ence/nhsuk-frontend_Textarea_with_error_message_-_focused_0_document_2_iPad.png b/...ence/nhsuk-frontend_Textarea_with_error_message_-_focused_0_document_2_iPad.png
diff --git a/...rontend_Textarea_with_error_message_-_focused_0_document_3_Surface_iPad_Pro.png b/...rontend_Textarea_with_error_message_-_focused_0_document_3_Surface_iPad_Pro.png
diff --git a/tests/backstop/engine_scripts/puppet/clickAndHoverHelper.js b/tests/backstop/engine_scripts/puppet/clickAndHoverHelper.js
@@ -6,24 +6,24 @@ module.exports = async (page, scenario) => {
 
   if (hoverSelector) {
     for (const hoverSelectorIndex of [].concat(hoverSelector)) {
-      await page.waitFor(hoverSelectorIndex);
+      await page.waitForSelector(hoverSelectorIndex);
       await page.hover(hoverSelectorIndex);
     }
   }
 
   if (clickSelector) {
     for (const clickSelectorIndex of [].concat(clickSelector)) {
-      await page.waitFor(clickSelectorIndex);
+      await page.waitForSelector(clickSelectorIndex);
       await page.click(clickSelectorIndex);
     }
   }
 
   if (postInteractionWait) {
-    await page.waitFor(postInteractionWait);
+    await page.waitForSelector(postInteractionWait);
   }
 
   if (scrollToSelector) {
-    await page.waitFor(scrollToSelector);
+    await page.waitForSelector(scrollToSelector);
     await page.evaluate(scrollToSelector => {
       document.querySelector(scrollToSelector).scrollIntoView();
     }, scrollToSelector);