Remove hardcoded Home link from navigation #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the link to
"/"
labelled"Home"
, which is currently hardcoded, and only shows up within the navigation menu on mobile screen widths.This link may not be appropriate for all services, which might not have a homepage, or might use a different path for it.
It is also unclear whether having a homepage link is needed in the navigation if the NHS logo also goes to the homepage, and if it is needed, whether it should always be present rather than only within the mobile menu.
Services who want to continue to include the Home link can do so by adding an additional class using the Header component like this:
This should probably be considered a breaking change, as services would need to update their HTML if they want to keep the Home link?
Checklist