Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blazor chat components #2541

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Blazor chat components #2541

merged 6 commits into from
Feb 18, 2025

Conversation

joseahdz
Copy link
Contributor

Pull Request

🤨 Rationale

Adding Blazor wrappers for Spright chat-components.

Spright chat-components were submitted in this PR #2529.

👩‍💻 Implementation

Added Blazor wrappers under SprightBlazor folder.

🧪 Testing

Added unit tests and all passed.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

jattasNI
jattasNI reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you intended this to be ready for buddy review, but I saw it and gave a couple early points of feedback.

@jattasNI
Copy link
Contributor

@joseahdz as far as I can see this is ready to move out of Draft once you've addressed my couple minor comments.

@joseahdz joseahdz marked this pull request as ready for review February 17, 2025 15:24
@rajsite rajsite merged commit 0a8c3b2 into main Feb 18, 2025
14 checks passed
@rajsite rajsite deleted the blazor-chat-components branch February 18, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI jattasNI approved these changes

@msmithNI msmithNI msmithNI approved these changes

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joseahdz @jattasNI @rajsite @msmithNI @atmgrifter00