Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new slots for the spright-chat-message to allow adding action buttons and follow-up prompts #2552

Merged
merged 48 commits into from
Apr 3, 2025
Merged

Added new slots for the spright-chat-message to allow adding action buttons and follow-up prompts #2552

merged 48 commits into from
Apr 3, 2025
+419 −46

Conversation

joseahdz
Copy link
Contributor

@joseahdz joseahdz commented Mar 12, 2025 •
edited by jattasNI
Loading

Pull Request

🤨 Rationale

UX design calls for adding action buttons to chat messages to allow user to edit prompts and provide feedback on AI responses.
Also, messages can have suggested follow-up button prompts and those should be below the action buttons.

👩‍💻 Implementation

  1. Updated spec and implementation to add slots footer-actions and end to allow adding buttons below the message.
  2. Updated styles (mostly padding) to more closely match the latest designs
  3. Added storybook docs for the new slots

🧪 Testing

New matrix test

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@joseahdz
Adding action controls slots to spright-chat-message
71b8aa0 
The action controls provide "actions" that can be done to the chat-message like copying and thumbs up/down.
@joseahdz
Change files
2468b3e
@joseahdz
Outbound messages have actions buttons on left side
7ac3e1b 
Action buttons on outbound messages appear on the left side when hovering over the message row
@joseahdz
Merge branch 'main' into chat-message-slots
afbce76 
* main:
  applying package updates [skip ci]
  Update to .net 8.0.406 (#2545)
  Changed Rich Text Viewer markdown property to an attribute (#2542)
  applying package updates [skip ci]
  Blazor chat components (#2541)
@joseahdz
Supporting slots to left and bottom of message
615e6fe
@joseahdz
Reserve space for edit button on the left side
6de7cb5
@joseahdz
Merge branch 'main' into chat-message-slots
ce1d2c0 
* main:
  Created Blazor wrapper for nimble-rich-text-viewer component (#2544)
@joseahdz
Reverted markdown example string change
d7b638e
@joseahdz
Merge branch 'main' into chat-message-slots
2a2432e 
* main:
  Add usage guidance about table column mapping performance (#2548)
  Improve usage guidance for select filter mode (#2549)
  applying package updates [skip ci]
  Update npm dependencies update to latest (#2547)
  Update npm dependencies lock update only (#2546)
  applying package updates [skip ci]
@joseahdz
Submitting latest changes including spec updates
24a8b91
@joseahdz
Merge branch 'main' into chat-message-slots
312a6c3 
* main:
  applying package updates [skip ci]
  Migrate to `@ni/fast-*` packages (#2550)
@joseahdz
Fixed compile error
e070c7e
@joseahdz
Some cleanup
35e5958
@joseahdz
Added interactive matrix
cd64240
@joseahdz
Minor rename
1a145d9
@joseahdz
Fixed linting errors
54b3b11
@joseahdz
Some small changes
b6efdc4
jattasNI
jattasNI reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looked at the spec and the docs, not the implementation yet

@joseahdz joseahdz marked this pull request as ready for review March 27, 2025 13:38
@joseahdz joseahdz requested review from rajsite and jattasNI April 1, 2025 02:27
jattasNI
jattasNI reviewed Apr 1, 2025
View reviewed changes
jattasNI
jattasNI reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed updates to the styles and tests. I still need to re-verify the storybook and chromatic diffs; I'll reset owners tomorrow once it looks good.

rajsite
rajsite approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rajsite rajsite enabled auto-merge (squash) April 3, 2025 00:04
@rajsite rajsite merged commit a271c6f into main Apr 3, 2025
12 checks passed
@rajsite rajsite deleted the chat-message-slots branch April 3, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jattasNI jattasNI jattasNI left review comments

@rajsite rajsite rajsite approved these changes

@atmgrifter00 atmgrifter00 Awaiting requested review from atmgrifter00 atmgrifter00 is a code owner

@mollykreis mollykreis Awaiting requested review from mollykreis mollykreis is a code owner

@msmithNI msmithNI Awaiting requested review from msmithNI msmithNI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joseahdz @rajsite @jattasNI @atmgrifter00