Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the most intrusive PR in today's series.
QUIC_...
variables and either remove or migrate toMSH3
./Qspectre
potentially take effect. (Note thatHAS_SPECTRE
is not wired to a visible option or active check in msh3. Maybe it should be removed entirely. The user can pass this with toolchain or variables.)_GNU_SOURCE
. (It was not needed in the past.)msh3_header
interface target:msh3
(subject to INSTALL_INTERFACE/BUILD_INTERFACE).C++17 is enough to build the lib now.Building the lib needs at least C++20 for "use of designated initializers" (MSVC).
(Not exported as a transitive usage requirement.)
WIN32_LEAN_AND_MEAN
is a project-wide definition. (Not exported as a transitive usage requirement.)VER_BUILD_ID
andVER_SUFFIX
are used only bymsh3
. (Not exported as a transitive usage requirement.) I didn't notice problems on non-windows.Linking
msh3app
andmhs3test
now looks as trivial as it should, with proper use of CMake.