Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissolve msh3_headers, cleanup #260

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Dissolve msh3_headers, cleanup #260

merged 2 commits into from
Jan 1, 2025

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 31, 2024

This is probably the most intrusive PR in today's series.

  • Revise QUIC_... variables and either remove or migrate to MSH3.
    • The vendored msquic build overrides the variables.
    • Let /Qspectre potentially take effect. (Note that HAS_SPECTRE is not wired to a visible option or active check in msh3. Maybe it should be removed entirely. The user can pass this with toolchain or variables.)
    • Drop _GNU_SOURCE. (It was not needed in the past.)
  • Remove the msh3_header interface target:
    • The actual include dir is a public property of msh3 (subject to INSTALL_INTERFACE/BUILD_INTERFACE).
    • C++17 is enough to build the lib now.
      Building the lib needs at least C++20 for "use of designated initializers" (MSVC).
      (Not exported as a transitive usage requirement.)
    • WIN32_LEAN_AND_MEAN is a project-wide definition. (Not exported as a transitive usage requirement.)
    • VER_BUILD_ID and VER_SUFFIX are used only by msh3. (Not exported as a transitive usage requirement.) I didn't notice problems on non-windows.
  • Add additional includes to msh3_app. Not sure why the Ubuntu build didn't complain before, but it did now.

Linking msh3app and mhs3test now looks as trivial as it should, with proper use of CMake.

@dg0yt dg0yt marked this pull request as draft December 31, 2024 20:00
@dg0yt dg0yt marked this pull request as ready for review December 31, 2024 21:09
@nibanks nibanks merged commit ba59503 into nibanks:main Jan 1, 2025
23 checks passed
@dg0yt dg0yt deleted the headers branch January 1, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants