Fix issue where merge and release label would never be added to PR #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
N/A.
Documentation
N/A.
Description
In #28, I changed how we set the
merge-and-release-compatiblelabel. However, I made one small oversight. In the flow where a user opens a draft PR, pushes all their commits to the draft PR, and only then marks the PR as non-draft / ready for review without any additional commits, when it comes time for deployment, the MnR label wouldn't be applied yet. I saw this out in the wild a few times. This PR fixes that problem by also triggering the labeling job onready_for_reviewevents.Testing Considerations
Tested through https://github.com/nicheinc/actions-go-ci/tree/test/actions%2329 which is called by https://github.com/nicheinc/fact/pull/432.
Deployment
main.Versioning
Not versioned.