Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid missing-field-initializers warn #89

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

zhongcy
Copy link

@zhongcy zhongcy commented Dec 5, 2024

avoid missing-field-initializers warn

cc -c ../ngx_upstream_jdomain-1.5.0/src/ngx_http_upstream_jdomain_module.c:120:15: error: missing initializer for field ‘sin_family’ of ‘struct sockaddr_in’ [-Werror=missing-field-initializers]
 static struct sockaddr_in NGX_JDOMAIN_INVALID_ADDR_SOCKADDR_IN = {};
               ^
In file included from /usr/include/bits/socket.h:151:0,
                 from /usr/include/sys/socket.h:39,
                 from src/os/unix/ngx_linux_config.h:44,
                 from src/core/ngx_config.h:26,
                 from ../ngx_upstream_jdomain-1.5.0/src/ngx_http_upstream_jdomain_module.c:2:
/usr/include/netinet/in.h:242:5: note: ‘sin_family’ declared here
     __SOCKADDR_COMMON (sin_);
     ^
cc1: all warnings being treated as errors
make[1]: *** [objs/addon/src/ngx_http_upstream_jdomain_module.o] Error 1
make[1]: *** Waiting for unfinished jobs....

@zhongcy
Copy link
Author

zhongcy commented Dec 9, 2024

@nicholaschiasson can you check it?

@nicholaschiasson
Copy link
Owner

Hi @zhongcy , LGTM, but since some workflow actions were outdated, please resync with master and then I will approve and merge.

@nicholaschiasson nicholaschiasson merged commit 6c0cc3a into nicholaschiasson:master Dec 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants