Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust git paths for command capture, repo clone destinations #13

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

nicholasjng
Copy link
Owner

Also updates the expected artifact locations, relative to the workspace.

Also updates the expected artifact locations, relative to the workspace.
nicholasjng and others added 4 commits March 11, 2024 19:45
They seem to be interpreted as part of the glob, which screws them up.
Also postprocess the files into a single directory to obtain a neater
artifact.
@nicholasjng nicholasjng force-pushed the add-compile-commands-job branch 2 times, most recently from fd5054c to c711bad Compare March 12, 2024 10:01
@nicholasjng nicholasjng force-pushed the add-compile-commands-job branch 2 times, most recently from ad7c051 to d78696e Compare March 12, 2024 11:24
@nicholasjng
Copy link
Owner Author

The latest iteration of the job finally produces compiler and linker artifacts for both CMake and Bazel, grouped by the runner OS. We could obtain the same order by setting build/${{ matrix.os }} as the build dir for CMake, but I'm fine with leaving as is.

Job and downloadable result artifacts: https://github.com/nicholasjng/nanobind-bazel/actions/runs/8248209027

@nicholasjng nicholasjng merged commit b8fe40e into master Mar 12, 2024
20 checks passed
@nicholasjng nicholasjng deleted the add-compile-commands-job branch March 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant