fix NullPointerException #733

tyf1946 · 2019-06-15T09:22:02Z

HomeActivity method onPrepareOptionsMenu
menu.findItem(R.id.menu_designer_news_login) return null object
use onCreateOptionsMenu find menu_designer_news_login

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I ran ./gradlew spotlessApply before submitting the PR
I reviewed submitted code
I added tests to verify changes
All tests passing

🔮 Next steps

📸 Screenshots / GIFs

HomeActivity method onPrepareOptionsMenu menu.findItem(R.id.menu_designer_news_login) return null object use onCreateOptionsMenu find menu_designer_news_login

googlebot · 2019-06-15T09:22:04Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-06-15T09:22:05Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

keyboardsurfer · 2019-07-10T09:37:20Z

Hi and thanks for your contribution.
Before we can continue with this, please make sure both checks go through.

keyboardsurfer · 2019-07-10T09:37:43Z

app/src/main/java/io/plaidapp/ui/HomeActivity.kt

@@ -100,6 +100,7 @@ class HomeActivity : AppCompatActivity() {
    private lateinit var loading: ProgressBar
    private lateinit var feedAdapter: FeedAdapter
    private lateinit var filtersList: RecyclerView
+    private lateinit var mDesignerNewsLogin: MenuItem


Please don't use m prefix.

Also I recommend not to hold on to the item in the activity scope.

thanks for your suggestion

keyboardsurfer · 2019-07-10T09:38:49Z

app/src/main/java/io/plaidapp/ui/HomeActivity.kt

@@ -450,6 +450,12 @@ class HomeActivity : AppCompatActivity() {
        return true
    }

+    override fun onCreateOptionsMenu(menu: Menu?): Boolean {
+        menuInflater.inflate(R.menu.main,menu)
+        mDesignerNewsLogin = menu!!.findItem(R.id.menu_designer_news_login)


Don't use !! where it can be avoided.
In this case, checking whether menu is not null is valid.

thanks for your suggestion

tyf1946 · 2019-07-12T07:21:47Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).

The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.

The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

I signed it!

googlebot · 2019-07-12T07:21:50Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2019-07-12T07:21:50Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

florina-muntenescu · 2019-11-25T10:29:52Z

Run gradlew spotlessApply please

keyboardsurfer

Please address my review comments in order to proceed on this PR.

fix NullPointerException

18af88a

HomeActivity method onPrepareOptionsMenu menu.findItem(R.id.menu_designer_news_login) return null object use onCreateOptionsMenu find menu_designer_news_login

googlebot added the cla: no label Jun 15, 2019

keyboardsurfer requested changes Jul 10, 2019

View reviewed changes

googlebot added cla: yes and removed cla: no labels Jul 12, 2019

florina-muntenescu assigned keyboardsurfer Nov 25, 2019

keyboardsurfer requested changes Nov 25, 2019

View reviewed changes

codingjeremy changed the base branch from master to main September 29, 2020 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix NullPointerException #733

fix NullPointerException #733

tyf1946 commented Jun 15, 2019 •

edited

Loading

googlebot commented Jun 15, 2019

googlebot commented Jun 15, 2019

keyboardsurfer commented Jul 10, 2019

keyboardsurfer Jul 10, 2019

keyboardsurfer Jul 10, 2019

tyf1946 Jul 11, 2019

keyboardsurfer Jul 10, 2019

tyf1946 Jul 11, 2019

tyf1946 commented Jul 12, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Jul 12, 2019

googlebot commented Jul 12, 2019

florina-muntenescu commented Nov 25, 2019

keyboardsurfer left a comment

fix NullPointerException #733

Are you sure you want to change the base?

fix NullPointerException #733

Conversation

tyf1946 commented Jun 15, 2019 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

📸 Screenshots / GIFs

googlebot commented Jun 15, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Jun 15, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

keyboardsurfer commented Jul 10, 2019

keyboardsurfer Jul 10, 2019

Choose a reason for hiding this comment

keyboardsurfer Jul 10, 2019

Choose a reason for hiding this comment

tyf1946 Jul 11, 2019

Choose a reason for hiding this comment

keyboardsurfer Jul 10, 2019

Choose a reason for hiding this comment

tyf1946 Jul 11, 2019

Choose a reason for hiding this comment

tyf1946 commented Jul 12, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Jul 12, 2019

googlebot commented Jul 12, 2019

florina-muntenescu commented Nov 25, 2019

keyboardsurfer left a comment

Choose a reason for hiding this comment

tyf1946 commented Jun 15, 2019 •

edited

Loading