-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ferini/kotlin gradle dsl #811
Conversation
Hi, thanks for the PR. How is this different to #807? |
Hi, I did this as part of experimenting with kotlin DSL on a separate branch and wanted a way to share the diff of what was done. It was not intended to be merged in this state, that's why it is only draft. In the hindsight, I probably could just create a PR in my forked repo. I saw the other one already exists and it is mostly similar to this one. I took some different approach in some areas (eg. I kept separate shared_dependencies.gradle.kts and test_dependencies.gradle.kts and moved them to buildSrc as precompiled plugins), but I am not sure if that makes this one better suitable than the other. If you want to check it out and think this might be better candidate to merge, I am happy to clean it up, otherwise feel free to close it. |
@pfmaggi FYI |
Thanks @ghus-raba for the PR, I'm updating #807 using some of the ideas you used here. |
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
./gradlew spotlessApply
before submitting the PR🔮 Next steps
📸 Screenshots / GIFs